-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve secondary calibration #208
Comments
Up to now there are three calibration strategies:
|
Coming to what is not working, there are some problems with the current implemented calibration methods. link calibration* and chain calibration depends on subtrees created using
|
In order to overcome the weakness of the implemented calibration methods I thought about other possible calibration methods that might be implemented:
I have done a preliminary implementation of this two methods, plus a refactoring of the previously implemented methods in https://github.com/lrapetti/human-dynamics-estimation/tree/improve-calibration, I'll try to test them and eventually open a PR depending on the results. |
You are probably right. Not sure why I was working back then. I guess that by not taking into consideration the lower part, we did not spot any other issue. |
cc @kouroshD |
cc @lrapetti |
Almost ready with the review. Just waiting for a final test @lrapetti |
Mereged #211, closing. |
Some options of the secondary calibration are currently not working for some model (e.g. the chain tree calibration for the
iCub
model). Those problem should be investigated, and furthermore a general refactoring might be useful.I'll first try to sum-up what is there, what is working and what not.
The text was updated successfully, but these errors were encountered: