Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export CanOpenNode c file fails if subindex contains the character "%" #53

Closed
trojanobelix opened this issue Feb 1, 2017 · 1 comment

Comments

@trojanobelix
Copy link
Contributor

e.g. if the sub index name is
"Actual alcohol value in vol.-%"

@robincornelius
Copy link
Owner

make_cname() fails when special characters are present. Mostly because of the splitting Regex.Split(name,@"[\W]+") and an unchecked direct substring access.

Its actually the - not the % causing the issue and i did a simple fix but it still fails for things like -test- etc so needs some more work to come up with a cleaner solution. May be strip special characters first as they cannot be used in c variable names anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants