Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding new subobject to array: inherit dataType, accessType, PDOmapping? #43

Closed
ghost opened this issue Dec 15, 2016 · 1 comment
Closed

Comments

@ghost
Copy link

ghost commented Dec 15, 2016

I'm talking about this line.
Should this not be the datatype of the parent? Also inheriting accessType and PDOtype would be handy.

I'm not sure about this, so no pull request yet ;-)

@robincornelius
Copy link
Owner

Yes it probably should. Because you can easily end up loading files that do not specify data types for child objects, if the code finds a unknown data type and parent!=null it will always use the parent data type. So nothing bad is currently happening.

However we really should try to get the datatypes correct at the UI level and the protection against null child items should be at the import level. If i cleaned up this it would remove a fair chunk of code that is only there to deal with bad situations such as UNKNOWN datatypes ;-)

I'm currently between PCs so may take a day or two before i can get any coding done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant