-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After adding a new SDO, it is not accessable in PDO mapping dropdown #13
Comments
Hmm seems to be working here. If i create a new object, as soon as i change the PDO type to optional and hit save they are available in the PDO drop downs and the list of available PDOs. The save button should fire the doUpdatePDOs() which should propagate through and force the PDOs to completely refresh what is available. |
Looks like there are a few different things going on here.
I've also spotted when checking this morning that the parent entry for a REC object should grey out the PDO options but currently it allows this to be set on the parent when only the sub objects make sense. So the fault is array objects. This leads to another problem we must consider. Although you can do as your patch added and allow the pdo field to be set on all subobjects it presents a confusing situation when exporting to canopennode. The XML and EDS files both support fine grained permissions for PDO for subobjects so this is no problem. But when generating the main object dictionary in CO_OD.c arrays only have one flags field for the entire array so it is impossible to pick and choose different fields. (This is not the case for REC objects, these have individual field flags). I would suggest the following solution:-
|
You are right, i did not think this all the way through. |
I've implemented a patch that updates the subobjects and fixes the basic bug described here but not gone as far as allowing the individual ones to be set without the parent |
PDO-Map flag was set to optional.
Current workaround: save the XML and open it again..
The text was updated successfully, but these errors were encountered: