Show crashes/displays empty directory when looking at Google Drive Stream on macOS

[roberthawdon]

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

• I am running the latest version
• I checked the documentation and found no answer
• I checked to make sure that this issue has not already been filed
• I'm reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior

The contents of the directory should be shown

Current Behavior

Either a blank screen (resolves with an F5) or show crashes.

Failure Information (for bugs)

Please help provide information about the failure if this is a bug. If it is not a bug, please remove the rest of this template.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. Install Google Drive Stream
2. Use show and navigate to /Volumes/GoogleDrive

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

• DF-SHOW Version: 0.6.2 and 0.6.3-dev
• Operating System: macOS Mojave
• System Architecture: x86_64
• Output of uname -a: Darwin ████████████.local 18.2.0 Darwin Kernel Version 18.2.0: Thu Dec 20 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64 x86_64

Failure Logs

2019-03-08 11:42:58.225664+0000 show[25527:458432] detected buffer overflow
Process 25527 stopped
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
    frame #0: 0x00007fff5e25f23e libsystem_kernel.dylib`__pthread_kill + 10
libsystem_kernel.dylib`__pthread_kill:
->  0x7fff5e25f23e <+10>: jae    0x7fff5e25f248            ; <+20>
    0x7fff5e25f240 <+12>: movq   %rax, %rdi
    0x7fff5e25f243 <+15>: jmp    0x7fff5e2593b7            ; cerror_nocancel
    0x7fff5e25f248 <+20>: retq
Target 0: (show) stopped.
(lldb) next
Process 25527 exited with status = 0 (0x00000000) Terminated due to signal 6

[roberthawdon]

This is believed to be a bug in the underlying GNU libraries as the GNU ls has similar issues. Will keep this open for now, but a mitigation has been added to the develop branch.

[roberthawdon]

Will decide if this is worth pursuing or "Won't Fix" before the release of v0.7.0

[roberthawdon]

also observed in Midnight Commander, and nnn (Noice is Not Noice)

[roberthawdon]

also observed on lsd (https://github.com/Peltoche/lsd)

[roberthawdon]

Closing as it affects multiple projects, including GNU versions of ls. Seems to be an underlying issue.