From 181e91cba36962db5745b812c62cc860ec2789eb Mon Sep 17 00:00:00 2001 From: Brad Hughes Date: Tue, 4 May 2021 13:33:37 -0400 Subject: [PATCH 1/2] Help elements need a predictable ID --- .../core/src/components/fields/SchemaField.js | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/packages/core/src/components/fields/SchemaField.js b/packages/core/src/components/fields/SchemaField.js index 5f4087be23..2465b66912 100644 --- a/packages/core/src/components/fields/SchemaField.js +++ b/packages/core/src/components/fields/SchemaField.js @@ -85,14 +85,22 @@ function LabelInput(props) { } function Help(props) { - const { help } = props; + const { id, help } = props; if (!help) { return null; } if (typeof help === "string") { - return

{help}

; + return ( +

+ {help} +

+ ); } - return
{help}
; + return ( +
+ {help} +
+ ); } function ErrorList(props) { @@ -316,7 +324,7 @@ function SchemaFieldRender(props) { /> ), rawDescription: description, - help: , + help: , rawHelp: typeof help === "string" ? help : undefined, errors: , rawErrors: errors, From aff17f9e05f9c00697eda1fdabc91501a646ea78 Mon Sep 17 00:00:00 2001 From: Brad Hughes Date: Tue, 4 May 2021 16:40:30 -0400 Subject: [PATCH 2/2] Updated help id in semantic-ui theme --- packages/semantic-ui/src/FieldTemplate/FieldTemplate.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/semantic-ui/src/FieldTemplate/FieldTemplate.js b/packages/semantic-ui/src/FieldTemplate/FieldTemplate.js index 2da54e0f52..8f82e33714 100644 --- a/packages/semantic-ui/src/FieldTemplate/FieldTemplate.js +++ b/packages/semantic-ui/src/FieldTemplate/FieldTemplate.js @@ -31,7 +31,7 @@ function FieldTemplate({ )} )} - +