additionalProperties can't be added with semantic-ui fluent-ui themes

[ErQrYfkrju]

Prerequisites

• I have read the documentation;
• In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.
• Ideally, I'm providing a sample JSFiddle or a shared playground link demonstrating the issue.

Description

additionalProperties can`t be added with semantic-ui fluent-ui and material-ui themes

Steps to Reproduce

1. Goto https://rjsf-team.github.io/react-jsonschema-form/
2. Select additionalProperties example
3. Select theme material-ui, semantic-ui, fluent-ui

Expected behavior

Expected behavior should be as for default and antd themes

Actual behavior

Can`t add or remove additioanlProperties for selected object

Version

Latest version from npm

[bretep]

Just about to report the same issue, although I found it after upgrading to the latest.

[ValYouW]

Encountered into this also just now... any simple workaround?
I made a simple implementation of this feature by overriding ObjectFieldTemplate and FieldTemplate it seems to work on a very simple scenario, it's on CodeSandbox if anyone is interested...

[ErQrYfkrju]

any news?

[ErQrYfkrju]

@jacqueswho any news on semantic-ui?

[jacqueswho]

@ErQrYfkrju at the moment none of the themes support this feature. This is not a simple change and needs to be thought of how to integrate different themes to support this. One linear approach that all themes can use to support this feature

[ErQrYfkrju]

@jacqueswho Why none? Default, antd and now material-ui supports it. antd and material-ui adopted WrapIfAdditional component. I do not know where to start, to add support for semantic-ui...

[jacqueswho]

will look into this then. As I have not seen the latest development with other themes

[ErQrYfkrju]

@jacqueswho any news?

[jacqueswho]

@ErQrYfkrju waiting for this pull request to be approved. Will then look at implementing this. I have made quite a lot of code changes in this branch. I see I need to alter the Field Template to wrapAdditional

[jacqueswho]

@epicfaace There are going to be quite a few issues related to other themes not supporting the default behavior. I think we need to create a contributing guide doc, to assist others in the future. So we should either include utilities in the core and use them, or give some best practice guidance, direction. what do you think? we can create separate tasks for each to document how, and what to use to implement
The following are not quite clear

• Additional Properties

• theme specific props

• Date picker

• hidden fields

• Submit Button

[ErQrYfkrju]

@jacqueswho @epicfaace thanks for your work. Looking forward to see this feature implemented.....

[ErQrYfkrju]

@epicfaace ping

[epicfaace]

@epicfaace There are going to be quite a few issues related to other themes not supporting the default behavior. I think we need to create a contributing guide doc, to assist others in the future. So we should either include utilities in the core and use them, or give some best practice guidance, direction. what do you think? we can create separate tasks for each to document how, and what to use to implement
The following are not quite clear

• Additional Properties
• theme specific props
• Date picker
• hidden fields
• Submit Button

Yeah, that's a good point and a good idea. A separate "contributing guide" page might be helpful.

[ErQrYfkrju]

@epicfaace @jacqueswho Happy New Year!
Any news on this issue...?

[ErQrYfkrju]

@epicfaace ping

[jacqueswho]

@epicfaace @jacqueswho Happy New Year!
Any news on this issue...?

Waiting for the pull request to be approved. sorry

[epicfaace]

Sorry, I'll take a look soon.

[abemedia]

Same for Bootstrap 4. It doesn't support additionalProperties.

Edit: Have implemented it in a local fork. Will clean it up a bit tomorrow then submit the PR.

[jmcauhy]

Hello guys, any updates on the Semantic-ui theme?

[epicfaace]

No one's working on it currently, so if you would like to contribute a PR, that would be welcome.

[ErQrYfkrju]

No one's working on it currently, so if you would like to contribute a PR, that would be welcome.

Why no one? @jacqueswho is working on three pull requests #2224, #2225, #2227 to be able to close this issue...

[ErQrYfkrju]

@epicfaace please review following PR. I know you are very busy, but soon it would be one year anniversary for this issue. Thanks in advance!

[ErQrYfkrju]

Hi, once #2224, #2225, #2227 are already merged in could this issue be resolved?

[ErQrYfkrju]

@jacqueswho ping

[jacqueswho]

@epicfaace ill see if I have time this week

[ErQrYfkrju]

@jacqueswho ping

[ErQrYfkrju]

@jacqueswho is there any possibility to get this working using custom patch or dirty hacks?

[jacqueswho]

@ErQrYfkrju just got back from holiday. Will see if I can look at this next week. I have a branch for this that needs to be completed. Its just needs styling, positioning changes