Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append the source of default image service's compression settings in README #109

Closed
risu729 opened this issue May 18, 2024 · 0 comments · Fixed by #111
Closed

Append the source of default image service's compression settings in README #109

risu729 opened this issue May 18, 2024 · 0 comments · Fixed by #111
Assignees
@risu729
Labels
documentation Improvements or additions to documentation

Comments

@risu729
Copy link
Owner

risu729 commented May 18, 2024

In README, I mentioned the below.

The default image service uses the default compression settings of sharp, in which the compression ratio is medium.

I found the source of it in the Astro Discord server so I will append it to README.

astro-compress sets the compression level to the maximum, whereas astro:assets uses the default settings
We most likely could tune up the settings a bit, though we need to be careful about it taking too much time (notably because of SSR doing it at runtime)
ref: https://discord.com/channels/830184174198718474/830184175176122389/1168307099571331155
@risu729 risu729 added the documentation Improvements or additions to documentation label May 18, 2024
@risu729 risu729 self-assigned this May 18, 2024
@risu729 risu729 linked a pull request May 19, 2024 that will close this issue
docs(README.md): quote the source of default image service's compression settings #111
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@risu729 risu729

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
1 participant
@risu729