You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FONTSIZETERM_large is too small (110%) and would be better to set to either 120% or 125%.
FONTSIZETERM_large and FONTSIZETERM_larger both are set to 110%. It would be good to leave FONTSIZETERM_larger at 110% so that there is an intermediate size between normal and FONTSIZETERM_large.
Also FONTSIZETERM_small and FONTSIZETERM_smaller are both 80%. I propose changing FONTSIZETERM_smaller to 90%.
Or larger can be larger than large rather than normal, and smaller can be smaller than small rather than normal. (The intended relative sizing is not obvious from their different orderings in the list). It would be better to flip the enumeration order of small/smaller or large/larger to make this clearer.
In the MEI documentation, larger/smaller are relative units rather than absolute, but in verovio they are absolute:
So I would place in the order from largest to smallest: large, larger, normal, smaller, small so that they are relative to the normal size (and cannot be relative to the current size).
The text was updated successfully, but these errors were encountered:
For the two relative size, larger would be 6/5 larger and smaller8/9 smaller. That means that applying larger to a large font would not be the same size as x-large, but I don't think we can get around it. Any thoughts?
For the two relative size, larger would be 6/5 larger and smaller 8/9 smaller. That means that applying larger to a large font would not be the same size as x-large, but I don't think we can get around it. Any thoughts?
That sounds good. Larger is up a minor third and smaller is down a major second :-)
Here are the current symbolic fontsize to percentage mappings in include/vrv/attalternates.h
verovio/include/vrv/attalternates.h
Lines 67 to 80 in a9f4b75
FONTSIZETERM_large
is too small (110%) and would be better to set to either 120% or 125%.FONTSIZETERM_large
andFONTSIZETERM_larger
both are set to 110%. It would be good to leaveFONTSIZETERM_larger
at 110% so that there is an intermediate size between normal andFONTSIZETERM_large
.Also
FONTSIZETERM_small
andFONTSIZETERM_smaller
are both 80%. I propose changingFONTSIZETERM_smaller
to 90%.Or
larger
can be larger thanlarge
rather than normal, andsmaller
can be smaller thansmall
rather than normal. (The intended relative sizing is not obvious from their different orderings in the list). It would be better to flip the enumeration order of small/smaller or large/larger to make this clearer.In the MEI documentation, larger/smaller are relative units rather than absolute, but in verovio they are absolute:
https://music-encoding.org/guidelines/v4/data-types/data.fontsizeterm.html
So I would place in the order from largest to smallest: large, larger, normal, smaller, small so that they are relative to the normal size (and cannot be relative to the current size).
The text was updated successfully, but these errors were encountered: