Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batch: Use determined test to test query manager. #4051

Closed
Tracked by #1977
liurenjie1024 opened this issue Jul 20, 2022 · 3 comments
Closed
Tracked by #1977

batch: Use determined test to test query manager. #4051

liurenjie1024 opened this issue Jul 20, 2022 · 3 comments
Assignees
@wangrunji0408 @BowenXiao1999
Labels
component/batch Batch related related issue. no-issue-activity type/enhancement Improvements to existing implementation.

Comments

@liurenjie1024
Copy link
Contributor

liurenjie1024 commented Jul 20, 2022 •
edited
Loading

Query manager need to handle concurrent request, state changes, and I feel it's a good place to test with simulation framework.
@liurenjie1024 liurenjie1024 mentioned this issue Jul 20, 2022
Closed
18 tasks
@liurenjie1024 liurenjie1024 added type/enhancement Improvements to existing implementation. component/batch Batch related related issue. labels Jul 20, 2022
@github-actions
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@BowenXiao1999
Copy link
Contributor

Current Query Manager logic is simple, and we already used parallel test or MADSIM_TEST_NUM to test it. So I think we can make it as unplanned now.

@liurenjie1024
Copy link
Contributor Author

LGTM

@liurenjie1024 liurenjie1024 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangrunji0408 wangrunji0408

@BowenXiao1999 BowenXiao1999

Labels
component/batch Batch related related issue. no-issue-activity type/enhancement Improvements to existing implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liurenjie1024 @wangrunji0408 @BowenXiao1999