fix: initialize staking pal to null address if is operator

- save gas on pool creation and handle condition
RigoBlock · Oct 25, 2022 · caeec6d · caeec6d
1 parent 7a6e708
commit caeec6d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/contracts/staking/staking_pools/MixinStakingPool.sol b/contracts/staking/staking_pools/MixinStakingPool.sol
@@ -52,7 +52,7 @@ abstract contract MixinStakingPool is MixinStakingPoolRewards {
         address operator = IRigoblockV3Pool(payable(rigoblockPoolAddress)).owner();
 
         // add stakingPal, which receives part of operator reward
-        address stakingPal = msg.sender;
+        address stakingPal = msg.sender != operator ? msg.sender : address(0);
 
         // operator initially shares 30% with stakers
         uint32 operatorShare = uint32(700000);

diff --git a/contracts/staking/staking_pools/MixinStakingPoolRewards.sol b/contracts/staking/staking_pools/MixinStakingPoolRewards.sol
@@ -126,7 +126,9 @@ abstract contract MixinStakingPoolRewards is IStaking, MixinAbstract, MixinCumul
         (operatorReward, membersReward) = _computePoolRewardsSplit(pool.operatorShare, reward, membersStake);
 
         if (operatorReward > 0) {
-            if (pool.operator == pool.stakingPal) {
+
+            // if staking pal is null, pool operator receives full reward
+            if (pool.stakingPal == address(0)) {
                 // Transfer the operator's grg reward to the operator
                 getGrgContract().transfer(pool.operator, operatorReward);
             } else {