Skip to content

Commit

Permalink
feat: assert valid governance init params
Browse files Browse the repository at this point in the history
- governance initialization parameters are validated in governance strategy at governance deploy
  • Loading branch information
gabririgo committed Jan 28, 2023
1 parent 7df9141 commit 7d2fa59
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions contracts/governance/mixins/MixinInitializer.sol
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

pragma solidity >=0.8.0 <0.9.0;

import "../interfaces/IGovernanceStrategy.sol";
import "../interfaces/IRigoblockGovernanceFactory.sol";
import "./MixinStorage.sol";

Expand All @@ -33,6 +34,7 @@ abstract contract MixinInitializer is MixinStorage {
/// @inheritdoc IGovernanceInitializer
function initializeGovernance() external override onlyUninitialized {
IRigoblockGovernanceFactory.Parameters memory params = IRigoblockGovernanceFactory(msg.sender).parameters();
IGovernanceStrategy(params.governanceStrategy).assertValidInitParams(params);
_name().value = params.name;
_governanceStrategy().value = params.governanceStrategy;
_paramsWrapper().governanceParameters = GovernanceParameters({
Expand Down

0 comments on commit 7d2fa59

Please sign in to comment.