Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of include-hidden-files for actions/upload-artifact #447

Closed
Czaki opened this issue Sep 2, 2024 · 3 comments
Closed

Lack of include-hidden-files for actions/upload-artifact #447

Czaki opened this issue Sep 2, 2024 · 3 comments

Comments

@Czaki
Copy link

Czaki commented Sep 2, 2024

3 days ago the action team decided to add include-hidden-files for actions/upload-artifact@v4 and actions/upload-artifact@v3: actions/upload-artifact#602

This is a breaking change performed without bumping the major version. To fix our workflows, we need to use it, but actionlint steep fail napari/napari#7241

Based on the documentation https://github.com/rhysd/actionlint/blob/main/docs/checks.md#popular-action-inputs-validation-at-with it should be possible to easy regenerate the schema and release a new actionlint version.

@maikelvdh
Copy link
Contributor

This should be addressed by #446

@Czaki
Copy link
Author

Czaki commented Sep 3, 2024

For anyone who is stucked with this action failing, you may change uses: actions/upload-artifact@v4 to uses: actions/upload-artifact@v4.4.0 and this will disable actionlint validation of input parameters.

@rhysd
Copy link
Owner

rhysd commented Sep 23, 2024

This issue should be fixed by v1.7.2.

@rhysd rhysd closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants