Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge dev branch to main branch #945

Merged
merged 13 commits into from
Jun 24, 2023
Merged

chore: merge dev branch to main branch #945

merged 13 commits into from
Jun 24, 2023

Conversation

validcube
Copy link
Member

@validcube validcube commented Jun 15, 2023 •
edited
Loading

Merge dev branch to main branch

13 Commits (5+4+3+1)

  • 🎉 5 New Features
  • 🐛 4 Bug Fixes
  • 📝 3 Documentation Improvements
  • 🧹 1 Miscellaneous Changes

@TheAabedKhan
Copy link
Member

TheAabedKhan commented Jun 15, 2023 •
edited
Loading

I didn't understand what problem you faced with 5e7458f. Did you test it? Attach a screen recording if possible

@Ushie
Copy link
Member

Ushie commented Jun 15, 2023

Also this PR should wait for the remaining open PRs to be merged

@TheAabedKhan
Copy link
Member

The problem with this commit is that it selects all compatible (and universal) patches

@evademaster, can you attach a screen recording of the problem please?

@Ushie
Copy link
Member

Ushie commented Jun 17, 2023

The problem with this commit is that it selects all compatible (and universal) patches

@evademaster, can you attach a screen recording of the problem please?

@evademaster asked me to respond to you with this recording

Screen_Recording_20230615_175240.mp4

@TheAabedKhan
Copy link
Member

TheAabedKhan commented Jun 17, 2023 •
edited
Loading

Even if you remove the commit, the same patches are selected. That's because the app automatically selects the Default patches if you have never made any patches selection. Once you select just the patches you want, and hit Done, then it won't be overridden.

So, the PR does not have any issues. It doesn't break anything. It just stops the experimental patches from being selected (if Experimental patches support is turned off) while importing.

@validcube
Copy link
Member Author

Even if you remove the commit, the same patches are selected. That's because the app automatically selects the Default patches if you have never made any patches selection. Once you select just the patches you want, and hit Done, then it won't be overridden.

So, the PR does not have any issues. It doesn't break anything. It just stops the experimental patches from being selected (if Experimental patches support is turned off) while importing.

Ah sorry about that, I have remove the warning status of this PR, and I'm sorry about the late reply too, I'm very busy right now.

@Ushie Ushie marked this pull request as ready for review June 23, 2023 18:09
@Ushie Ushie requested a review from Aunali321 June 23, 2023 18:09
Aunali321
Aunali321 approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@Aunali321 Aunali321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ushie Ushie merged commit 9663e3f into main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aunali321 Aunali321 Aunali321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@validcube @TheAabedKhan @Ushie @Aunali321 @ponces @oSumAtrIX @taku-nm