-
-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(updater): download successful dialog #938
Conversation
If this UI/UX change is the same as the screenshot, then I would like to suggest some changes. "Update downloaded!" text being shown in place of the progress bar, could be placed in the position of "downloading update...". Once the download completes, the text could change into "Download completed"/"Update downloaded" and then the user can update by tapping the update button. |
After you resolve the issue raised in the comment above, this can be merged |
New UI after fixes. Please have a look, @Ushie |
Maybe the Update button should be renamed to Install instead? |
The package installer shows Update and Cancel, so the UI also has the same options. Let me know if I should replace the Update to Install anyway. |
I think the progress bar doesn't need to be there anymore, what about text instead? "Do you want to install this update?" or something along the lines of that |
@Ushie check the recent commit. |
I second this. Why press update twice, when downloading and installing.
Would make more sense with this as well. |
The package installer will automatically open after the update is downloaded so a user can't see what's written on the dialog box. If the user mistakenly cancels the installer, then the user can see the text that says, "Continue to install the update?" which makes more sense. |
That text sounds good |
Have you been able to make time to update the text? |
What text to what? |
Oh my mistake, completely missed that commit |
When a user knowingly or unknowingly cancels or closes the installer window, there must be a dialog box which allows the user to launch the installer window again.