Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Allocate JobId instead of using hashcodes as job identifiers #31

Closed
dolmen opened this issue May 25, 2022 · 1 comment · Fixed by #84
Closed

api: Allocate JobId instead of using hashcodes as job identifiers #31

dolmen opened this issue May 25, 2022 · 1 comment · Fixed by #84

Comments

@dolmen
Copy link

dolmen commented May 25, 2022

Suggestions for API change:

  • define a type JobId
  • allocate JobId when ScheduleJob is called and return the JobId
  • change GetJobKeys/DeleteJob/GetScheduledJob to use JobId
  • remove method Key from Job interface
@dolmen dolmen changed the title Allocate JobId instead of using hashcodes as job identifiers api: Allocate JobId instead of using hashcodes as job identifiers May 25, 2022
@dolmen
Copy link
Author

dolmen commented May 25, 2022

This should fix #22.

@reugn reugn linked a pull request Jan 5, 2024 that will close this issue
feat!: introduce JobDetail and JobKey for job scheduling #84
Merged
@reugn reugn closed this as completed in #84 Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: introduce JobDetail and JobKey for job scheduling reugn/go-quartz
1 participant
@dolmen