From 2b87f7c18eb18662e678cf6d4f2e09601748adee Mon Sep 17 00:00:00 2001
From: slinkydeveloper <francescoguard@gmail.com>
Date: Thu, 14 Nov 2024 15:57:34 +0100
Subject: [PATCH] Cleanup counter example types, bring in jackson parameter
 names, fix logging

---
 examples/build.gradle.kts                        |  3 +++
 .../java/my/restate/sdk/examples/Counter.java    | 16 ++++++++--------
 examples/src/main/resources/log4j2.properties    |  4 ++--
 3 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/examples/build.gradle.kts b/examples/build.gradle.kts
index 3b721b54..2e9e60a1 100644
--- a/examples/build.gradle.kts
+++ b/examples/build.gradle.kts
@@ -21,6 +21,7 @@ dependencies {
 
   implementation(platform(jacksonLibs.jackson.bom))
   implementation(jacksonLibs.jackson.jsr310)
+  implementation(jacksonLibs.jackson.parameter.names)
 
   implementation(kotlinLibs.kotlinx.coroutines)
   implementation(kotlinLibs.kotlinx.serialization.core)
@@ -40,3 +41,5 @@ application {
 tasks.withType<Jar> { this.enabled = false }
 
 tasks.withType<ShadowJar> { transform(ServiceFileTransformer::class.java) }
+
+tasks.withType<JavaCompile> { options.compilerArgs.add("-parameters") }
diff --git a/examples/src/main/java/my/restate/sdk/examples/Counter.java b/examples/src/main/java/my/restate/sdk/examples/Counter.java
index cfe7ab6d..baf2c7bb 100644
--- a/examples/src/main/java/my/restate/sdk/examples/Counter.java
+++ b/examples/src/main/java/my/restate/sdk/examples/Counter.java
@@ -32,7 +32,7 @@ public void reset(ObjectContext ctx) {
   }
 
   @Handler
-  public void add(ObjectContext ctx, Long request) {
+  public void add(ObjectContext ctx, long request) {
     long currentValue = ctx.get(TOTAL).orElse(0L);
     long newValue = currentValue + request;
     ctx.set(TOTAL, newValue);
@@ -40,12 +40,12 @@ public void add(ObjectContext ctx, Long request) {
 
   @Shared
   @Handler
-  public Long get(SharedObjectContext ctx) {
+  public long get(SharedObjectContext ctx) {
     return ctx.get(TOTAL).orElse(0L);
   }
 
   @Handler
-  public CounterUpdateResult getAndAdd(ObjectContext ctx, Long request) {
+  public CounterUpdateResult getAndAdd(ObjectContext ctx, long request) {
     LOG.info("Invoked get and add with {}", request);
 
     long currentValue = ctx.get(TOTAL).orElse(0L);
@@ -60,19 +60,19 @@ public static void main(String[] args) {
   }
 
   public static class CounterUpdateResult {
-    private final Long newValue;
-    private final Long oldValue;
+    private final long newValue;
+    private final long oldValue;
 
-    public CounterUpdateResult(Long newValue, Long oldValue) {
+    public CounterUpdateResult(long newValue, long oldValue) {
       this.newValue = newValue;
       this.oldValue = oldValue;
     }
 
-    public Long getNewValue() {
+    public long getNewValue() {
       return newValue;
     }
 
-    public Long getOldValue() {
+    public long getOldValue() {
       return oldValue;
     }
   }
diff --git a/examples/src/main/resources/log4j2.properties b/examples/src/main/resources/log4j2.properties
index 109e46d6..36318614 100644
--- a/examples/src/main/resources/log4j2.properties
+++ b/examples/src/main/resources/log4j2.properties
@@ -15,9 +15,9 @@ appender.console.filter.replay.0.type = KeyValuePair
 appender.console.filter.replay.0.key = restateInvocationStatus
 appender.console.filter.replay.0.value = REPLAYING
 
-# Restate logs to debug level
+# Restate logs to info level
 logger.app.name = dev.restate
-logger.app.level = error
+logger.app.level = info
 logger.app.additivity = false
 logger.app.appenderRef.console.ref = consoleLogger