diff --git a/crates/admin/src/cluster_controller/logs_controller.rs b/crates/admin/src/cluster_controller/logs_controller.rs index b1de6a8976..7623f15e11 100644 --- a/crates/admin/src/cluster_controller/logs_controller.rs +++ b/crates/admin/src/cluster_controller/logs_controller.rs @@ -1308,9 +1308,7 @@ pub struct LogsBasedPartitionProcessorPlacementHints<'a> { logs_controller: &'a LogsController, } -impl<'a> scheduler::PartitionProcessorPlacementHints - for LogsBasedPartitionProcessorPlacementHints<'a> -{ +impl scheduler::PartitionProcessorPlacementHints for LogsBasedPartitionProcessorPlacementHints<'_> { fn preferred_nodes(&self, partition_id: &PartitionId) -> impl Iterator { let log_id = LogId::from(*partition_id); diff --git a/crates/admin/src/cluster_controller/scheduler.rs b/crates/admin/src/cluster_controller/scheduler.rs index 09225273ad..2991336441 100644 --- a/crates/admin/src/cluster_controller/scheduler.rs +++ b/crates/admin/src/cluster_controller/scheduler.rs @@ -551,13 +551,13 @@ impl<'a> TargetPartitionPlacementState<'a> { } } -impl<'a> TargetPartitionPlacementState<'a> { +impl TargetPartitionPlacementState<'_> { pub fn contains(&self, value: PlainNodeId) -> bool { self.node_set.contains(value) } } -impl<'a> Drop for TargetPartitionPlacementState<'a> { +impl Drop for TargetPartitionPlacementState<'_> { fn drop(&mut self) { if let Some(node_id) = self.leader.take() { self.node_set.set_leader(node_id); @@ -917,7 +917,7 @@ mod tests { partition_table: &'a PartitionTable, } - impl<'a> Matcher for PartitionTableMatcher<'a> { + impl Matcher for PartitionTableMatcher<'_> { type ActualT = ObservedClusterState; fn matches(&self, actual: &Self::ActualT) -> MatcherResult { diff --git a/crates/bifrost/src/providers/replicated_loglet/sequencer/appender.rs b/crates/bifrost/src/providers/replicated_loglet/sequencer/appender.rs index ff9e5c3fa2..662ff14d5d 100644 --- a/crates/bifrost/src/providers/replicated_loglet/sequencer/appender.rs +++ b/crates/bifrost/src/providers/replicated_loglet/sequencer/appender.rs @@ -406,7 +406,7 @@ struct LogServerStoreTask<'a, T> { timeout_at: MillisSinceEpoch, } -impl<'a, T: TransportConnect> LogServerStoreTask<'a, T> { +impl LogServerStoreTask<'_, T> { #[instrument( skip_all, fields( diff --git a/crates/core/src/network/connection.rs b/crates/core/src/network/connection.rs index 110848d2f3..b77ad101ef 100644 --- a/crates/core/src/network/connection.rs +++ b/crates/core/src/network/connection.rs @@ -43,7 +43,7 @@ pub struct SendPermit<'a, M> { _phantom: std::marker::PhantomData, } -impl<'a, M> SendPermit<'a, M> +impl SendPermit<'_, M> where M: WireEncode + Targeted, { @@ -76,7 +76,7 @@ where } } -impl<'a, M> SendPermit<'a, M> { +impl SendPermit<'_, M> { /// Sends a raw pre-serialized message over this permit. /// /// Note that sending messages over this permit won't use the peer information nor the connection diff --git a/crates/core/src/partitions.rs b/crates/core/src/partitions.rs index a8a7dfabae..ba0226f443 100644 --- a/crates/core/src/partitions.rs +++ b/crates/core/src/partitions.rs @@ -184,10 +184,10 @@ impl PartitionRoutingRefresher { } fn spawn_sync_routing_information_task(&mut self) { - if !self + if self .inflight_refresh_task .as_ref() - .is_some_and(|t| !t.is_finished()) + .is_none_or(|t| t.is_finished()) { let task = TaskCenter::spawn_unmanaged( TaskKind::Disposable, diff --git a/crates/ingress-http/src/layers/tracing_context_extractor.rs b/crates/ingress-http/src/layers/tracing_context_extractor.rs index f8b90840c9..01302a5347 100644 --- a/crates/ingress-http/src/layers/tracing_context_extractor.rs +++ b/crates/ingress-http/src/layers/tracing_context_extractor.rs @@ -54,7 +54,7 @@ where // https://github.com/open-telemetry/opentelemetry-rust/blob/ef4701055cc39d3448d5e5392812ded00cdd4476/opentelemetry-http/src/lib.rs#L14 License APL 2.0 pub struct HeaderExtractor<'a>(pub &'a HeaderMap); -impl<'a> Extractor for HeaderExtractor<'a> { +impl Extractor for HeaderExtractor<'_> { /// Get a value for a key from the HeaderMap. If the value is not valid ASCII, returns None. fn get(&self, key: &str) -> Option<&str> { self.0.get(key).and_then(|value| value.to_str().ok()) diff --git a/crates/log-server/src/rocksdb_logstore/record_format.rs b/crates/log-server/src/rocksdb_logstore/record_format.rs index 181ddd5a17..1a156fd654 100644 --- a/crates/log-server/src/rocksdb_logstore/record_format.rs +++ b/crates/log-server/src/rocksdb_logstore/record_format.rs @@ -77,7 +77,7 @@ impl<'a> DataRecordDecoder<'a> { #[derive(derive_more::From)] pub(super) struct DataRecordEncoder<'a>(&'a Record); -impl<'a> DataRecordEncoder<'a> { +impl DataRecordEncoder<'_> { /// On-disk record layout. /// For the record header, byte-order is little-endian. /// diff --git a/crates/partition-store/src/deduplication_table/mod.rs b/crates/partition-store/src/deduplication_table/mod.rs index 5fbcaa60df..17353d6fa2 100644 --- a/crates/partition-store/src/deduplication_table/mod.rs +++ b/crates/partition-store/src/deduplication_table/mod.rs @@ -88,7 +88,7 @@ impl ReadOnlyDeduplicationTable for PartitionStore { } } -impl<'a> ReadOnlyDeduplicationTable for PartitionStoreTransaction<'a> { +impl ReadOnlyDeduplicationTable for PartitionStoreTransaction<'_> { async fn get_dedup_sequence_number( &mut self, producer_id: &ProducerId, @@ -101,7 +101,7 @@ impl<'a> ReadOnlyDeduplicationTable for PartitionStoreTransaction<'a> { } } -impl<'a> DeduplicationTable for PartitionStoreTransaction<'a> { +impl DeduplicationTable for PartitionStoreTransaction<'_> { async fn put_dedup_seq_number( &mut self, producer_id: ProducerId, diff --git a/crates/partition-store/src/fsm_table/mod.rs b/crates/partition-store/src/fsm_table/mod.rs index 78cca13c3d..4d8b3767a9 100644 --- a/crates/partition-store/src/fsm_table/mod.rs +++ b/crates/partition-store/src/fsm_table/mod.rs @@ -82,7 +82,7 @@ impl ReadOnlyFsmTable for PartitionStore { } } -impl<'a> ReadOnlyFsmTable for PartitionStoreTransaction<'a> { +impl ReadOnlyFsmTable for PartitionStoreTransaction<'_> { async fn get_inbox_seq_number(&mut self) -> Result { get::(self, self.partition_id(), fsm_variable::INBOX_SEQ_NUMBER) .map(|opt| opt.map(Into::into).unwrap_or_default()) @@ -99,7 +99,7 @@ impl<'a> ReadOnlyFsmTable for PartitionStoreTransaction<'a> { } } -impl<'a> FsmTable for PartitionStoreTransaction<'a> { +impl FsmTable for PartitionStoreTransaction<'_> { async fn put_applied_lsn(&mut self, lsn: Lsn) { put( self, diff --git a/crates/partition-store/src/idempotency_table/mod.rs b/crates/partition-store/src/idempotency_table/mod.rs index 552ba77150..d2847704a4 100644 --- a/crates/partition-store/src/idempotency_table/mod.rs +++ b/crates/partition-store/src/idempotency_table/mod.rs @@ -120,7 +120,7 @@ impl ReadOnlyIdempotencyTable for PartitionStore { } } -impl<'a> ReadOnlyIdempotencyTable for PartitionStoreTransaction<'a> { +impl ReadOnlyIdempotencyTable for PartitionStoreTransaction<'_> { async fn get_idempotency_metadata( &mut self, idempotency_id: &IdempotencyId, @@ -137,7 +137,7 @@ impl<'a> ReadOnlyIdempotencyTable for PartitionStoreTransaction<'a> { } } -impl<'a> IdempotencyTable for PartitionStoreTransaction<'a> { +impl IdempotencyTable for PartitionStoreTransaction<'_> { async fn put_idempotency_metadata( &mut self, idempotency_id: &IdempotencyId, diff --git a/crates/partition-store/src/inbox_table/mod.rs b/crates/partition-store/src/inbox_table/mod.rs index 32eee39f2c..54f4655060 100644 --- a/crates/partition-store/src/inbox_table/mod.rs +++ b/crates/partition-store/src/inbox_table/mod.rs @@ -119,7 +119,7 @@ impl ReadOnlyInboxTable for PartitionStore { } } -impl<'a> ReadOnlyInboxTable for PartitionStoreTransaction<'a> { +impl ReadOnlyInboxTable for PartitionStoreTransaction<'_> { fn peek_inbox( &mut self, service_id: &ServiceId, @@ -144,7 +144,7 @@ impl<'a> ReadOnlyInboxTable for PartitionStoreTransaction<'a> { } } -impl<'a> InboxTable for PartitionStoreTransaction<'a> { +impl InboxTable for PartitionStoreTransaction<'_> { async fn put_inbox_entry( &mut self, inbox_sequence_number: MessageIndex, diff --git a/crates/partition-store/src/invocation_status_table/mod.rs b/crates/partition-store/src/invocation_status_table/mod.rs index b8bd0c7041..d9434085c1 100644 --- a/crates/partition-store/src/invocation_status_table/mod.rs +++ b/crates/partition-store/src/invocation_status_table/mod.rs @@ -324,7 +324,7 @@ impl ReadOnlyInvocationStatusTable for PartitionStore { } } -impl<'a> ReadOnlyInvocationStatusTable for PartitionStoreTransaction<'a> { +impl ReadOnlyInvocationStatusTable for PartitionStoreTransaction<'_> { async fn get_invocation_status( &mut self, invocation_id: &InvocationId, @@ -350,7 +350,7 @@ impl<'a> ReadOnlyInvocationStatusTable for PartitionStoreTransaction<'a> { } } -impl<'a> InvocationStatusTable for PartitionStoreTransaction<'a> { +impl InvocationStatusTable for PartitionStoreTransaction<'_> { async fn put_invocation_status( &mut self, invocation_id: &InvocationId, diff --git a/crates/partition-store/src/journal_table/mod.rs b/crates/partition-store/src/journal_table/mod.rs index 21188a1d7c..300c4786b6 100644 --- a/crates/partition-store/src/journal_table/mod.rs +++ b/crates/partition-store/src/journal_table/mod.rs @@ -163,7 +163,7 @@ impl ReadOnlyJournalTable for PartitionStore { } } -impl<'a> ReadOnlyJournalTable for PartitionStoreTransaction<'a> { +impl ReadOnlyJournalTable for PartitionStoreTransaction<'_> { async fn get_journal_entry( &mut self, invocation_id: &InvocationId, @@ -191,7 +191,7 @@ impl<'a> ReadOnlyJournalTable for PartitionStoreTransaction<'a> { } } -impl<'a> JournalTable for PartitionStoreTransaction<'a> { +impl JournalTable for PartitionStoreTransaction<'_> { async fn put_journal_entry( &mut self, invocation_id: &InvocationId, diff --git a/crates/partition-store/src/journal_table_v2/mod.rs b/crates/partition-store/src/journal_table_v2/mod.rs index 260194bbd9..7d6bea83c0 100644 --- a/crates/partition-store/src/journal_table_v2/mod.rs +++ b/crates/partition-store/src/journal_table_v2/mod.rs @@ -346,7 +346,7 @@ impl ReadOnlyJournalTable for PartitionStore { } } -impl<'a> ReadOnlyJournalTable for PartitionStoreTransaction<'a> { +impl ReadOnlyJournalTable for PartitionStoreTransaction<'_> { async fn get_journal_entry( &mut self, invocation_id: InvocationId, @@ -389,7 +389,7 @@ impl<'a> ReadOnlyJournalTable for PartitionStoreTransaction<'a> { } } -impl<'a> JournalTable for PartitionStoreTransaction<'a> { +impl JournalTable for PartitionStoreTransaction<'_> { async fn put_journal_entry( &mut self, invocation_id: InvocationId, diff --git a/crates/partition-store/src/keys.rs b/crates/partition-store/src/keys.rs index 0027894ab2..67b544f1e4 100644 --- a/crates/partition-store/src/keys.rs +++ b/crates/partition-store/src/keys.rs @@ -439,7 +439,7 @@ impl KeyCodec for Option { } } -impl<'a> KeyCodec for &'a [u8] { +impl KeyCodec for &[u8] { fn encode(&self, target: &mut B) { target.put(*self); } diff --git a/crates/partition-store/src/outbox_table/mod.rs b/crates/partition-store/src/outbox_table/mod.rs index 3b0b0b524b..035770a654 100644 --- a/crates/partition-store/src/outbox_table/mod.rs +++ b/crates/partition-store/src/outbox_table/mod.rs @@ -150,13 +150,13 @@ impl OutboxTable for PartitionStore { } } -impl<'a> ReadOnlyOutboxTable for PartitionStoreTransaction<'a> { +impl ReadOnlyOutboxTable for PartitionStoreTransaction<'_> { async fn get_outbox_head_seq_number(&mut self) -> Result> { get_outbox_head_seq_number(self, self.partition_id()) } } -impl<'a> OutboxTable for PartitionStoreTransaction<'a> { +impl OutboxTable for PartitionStoreTransaction<'_> { async fn put_outbox_message(&mut self, message_index: u64, outbox_message: &OutboxMessage) { add_message(self, self.partition_id(), message_index, outbox_message) } diff --git a/crates/partition-store/src/owned_iter.rs b/crates/partition-store/src/owned_iter.rs index 6a74b2ef03..08867ce85d 100644 --- a/crates/partition-store/src/owned_iter.rs +++ b/crates/partition-store/src/owned_iter.rs @@ -25,7 +25,7 @@ impl<'a, DB: DBAccess> OwnedIterator<'a, DB> { } } -impl<'a, DB: DBAccess> Iterator for OwnedIterator<'a, DB> { +impl Iterator for OwnedIterator<'_, DB> { type Item = (Bytes, Bytes); #[inline] diff --git a/crates/partition-store/src/partition_store.rs b/crates/partition-store/src/partition_store.rs index fffa134c0f..2a8f5cd48b 100644 --- a/crates/partition-store/src/partition_store.rs +++ b/crates/partition-store/src/partition_store.rs @@ -557,7 +557,7 @@ pub struct PartitionStoreTransaction<'a> { value_buffer: &'a mut BytesMut, } -impl<'a> PartitionStoreTransaction<'a> { +impl PartitionStoreTransaction<'_> { pub(crate) fn prefix_iterator( &self, table: TableKind, @@ -627,7 +627,7 @@ fn assert_partition_key( "Partition key '{partition_key}' is not part of PartitionStore's partition '{partition_key_range:?}'. This indicates a bug."); } -impl<'a> Transaction for PartitionStoreTransaction<'a> { +impl Transaction for PartitionStoreTransaction<'_> { async fn commit(self) -> Result<()> { // We cannot directly commit the txn because it might fail because of unrelated concurrent // writes to RocksDB. However, it is safe to write the WriteBatch for a given partition, @@ -660,7 +660,7 @@ impl<'a> Transaction for PartitionStoreTransaction<'a> { } } -impl<'a> StorageAccess for PartitionStoreTransaction<'a> { +impl StorageAccess for PartitionStoreTransaction<'_> { type DBAccess<'b> = DB where diff --git a/crates/partition-store/src/promise_table/mod.rs b/crates/partition-store/src/promise_table/mod.rs index 4ff702038d..e3bfd57651 100644 --- a/crates/partition-store/src/promise_table/mod.rs +++ b/crates/partition-store/src/promise_table/mod.rs @@ -126,7 +126,7 @@ impl ReadOnlyPromiseTable for PartitionStore { } } -impl<'a> ReadOnlyPromiseTable for PartitionStoreTransaction<'a> { +impl ReadOnlyPromiseTable for PartitionStoreTransaction<'_> { async fn get_promise( &mut self, service_id: &ServiceId, @@ -144,7 +144,7 @@ impl<'a> ReadOnlyPromiseTable for PartitionStoreTransaction<'a> { } } -impl<'a> PromiseTable for PartitionStoreTransaction<'a> { +impl PromiseTable for PartitionStoreTransaction<'_> { async fn put_promise(&mut self, service_id: &ServiceId, key: &ByteString, promise: &Promise) { self.assert_partition_key(service_id); put_promise(self, service_id, key, promise) diff --git a/crates/partition-store/src/service_status_table/mod.rs b/crates/partition-store/src/service_status_table/mod.rs index 8184b4b1e5..15b910b583 100644 --- a/crates/partition-store/src/service_status_table/mod.rs +++ b/crates/partition-store/src/service_status_table/mod.rs @@ -118,7 +118,7 @@ impl ReadOnlyVirtualObjectStatusTable for PartitionStore { } } -impl<'a> ReadOnlyVirtualObjectStatusTable for PartitionStoreTransaction<'a> { +impl ReadOnlyVirtualObjectStatusTable for PartitionStoreTransaction<'_> { async fn get_virtual_object_status( &mut self, service_id: &ServiceId, @@ -135,7 +135,7 @@ impl<'a> ReadOnlyVirtualObjectStatusTable for PartitionStoreTransaction<'a> { } } -impl<'a> VirtualObjectStatusTable for PartitionStoreTransaction<'a> { +impl VirtualObjectStatusTable for PartitionStoreTransaction<'_> { async fn put_virtual_object_status( &mut self, service_id: &ServiceId, diff --git a/crates/partition-store/src/state_table/mod.rs b/crates/partition-store/src/state_table/mod.rs index 7e807bd80a..c53a127b85 100644 --- a/crates/partition-store/src/state_table/mod.rs +++ b/crates/partition-store/src/state_table/mod.rs @@ -159,7 +159,7 @@ impl ReadOnlyStateTable for PartitionStore { } } -impl<'a> ReadOnlyStateTable for PartitionStoreTransaction<'a> { +impl ReadOnlyStateTable for PartitionStoreTransaction<'_> { fn get_user_state( &mut self, service_id: &ServiceId, @@ -182,7 +182,7 @@ impl<'a> ReadOnlyStateTable for PartitionStoreTransaction<'a> { } } -impl<'a> StateTable for PartitionStoreTransaction<'a> { +impl StateTable for PartitionStoreTransaction<'_> { fn put_user_state( &mut self, service_id: &ServiceId, diff --git a/crates/partition-store/src/timer_table/mod.rs b/crates/partition-store/src/timer_table/mod.rs index d460dc9bf3..2f192d29a8 100644 --- a/crates/partition-store/src/timer_table/mod.rs +++ b/crates/partition-store/src/timer_table/mod.rs @@ -195,7 +195,7 @@ impl TimerTable for PartitionStore { } } -impl<'a> TimerTable for PartitionStoreTransaction<'a> { +impl TimerTable for PartitionStoreTransaction<'_> { async fn put_timer(&mut self, key: &TimerKey, timer: &Timer) { add_timer(self, self.partition_id(), key, timer) } diff --git a/crates/serde-util/src/byte_count.rs b/crates/serde-util/src/byte_count.rs index 27c0f570f3..a17970d7d7 100644 --- a/crates/serde-util/src/byte_count.rs +++ b/crates/serde-util/src/byte_count.rs @@ -176,7 +176,7 @@ struct ByteCountVisitor; // it's actually compile-time, compiler will inline the comparison but we need // to make clippy happy. #[allow(clippy::absurd_extreme_comparisons)] -impl<'de, const CAN_BE_ZERO: bool> Visitor<'de> for ByteCountVisitor { +impl Visitor<'_> for ByteCountVisitor { type Value = ByteCount; fn expecting(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result { formatter.write_str("an integer or string") diff --git a/crates/service-client/src/http.rs b/crates/service-client/src/http.rs index 7a901a0a98..96482d1c53 100644 --- a/crates/service-client/src/http.rs +++ b/crates/service-client/src/http.rs @@ -238,7 +238,7 @@ impl From for HttpError { struct FormatHyperError<'a>(&'a hyper_util::client::legacy::Error); -impl<'a> fmt::Display for FormatHyperError<'a> { +impl fmt::Display for FormatHyperError<'_> { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { if let Some(source) = self.0.source() { write!(f, "{}, {}", self.0, source) diff --git a/crates/service-client/src/request_identity/v1.rs b/crates/service-client/src/request_identity/v1.rs index 28dba1c393..ad906a31c0 100644 --- a/crates/service-client/src/request_identity/v1.rs +++ b/crates/service-client/src/request_identity/v1.rs @@ -121,7 +121,7 @@ impl<'key, 'aud> Signer<'key, 'aud> { } } -impl<'key, 'aud> super::SignRequest for Signer<'key, 'aud> { +impl super::SignRequest for Signer<'_, '_> { type Error = jsonwebtoken::errors::Error; fn insert_identity(self, mut headers: HeaderMap) -> Result { let jwt = jsonwebtoken::encode( diff --git a/crates/storage-query-datafusion/src/physical_optimizer.rs b/crates/storage-query-datafusion/src/physical_optimizer.rs index 5cb687b2fa..ab62bdeef7 100644 --- a/crates/storage-query-datafusion/src/physical_optimizer.rs +++ b/crates/storage-query-datafusion/src/physical_optimizer.rs @@ -32,7 +32,7 @@ fn is_partition_key_column(arg: &PhysicalExprRef) -> bool { let Some(col) = arg.as_any().downcast_ref::() else { return false; }; - return col.name() == "partition_key"; + col.name() == "partition_key" } impl PhysicalOptimizerRule for JoinRewrite { diff --git a/crates/timer/src/service/tests.rs b/crates/timer/src/service/tests.rs index ce334a29a9..5da9b45a13 100644 --- a/crates/timer/src/service/tests.rs +++ b/crates/timer/src/service/tests.rs @@ -325,7 +325,6 @@ async fn earlier_timers_replace_older_ones() { } async fn yield_to_timer_service< - 'a, Timer: crate::Timer + Debug + 'static, Clock: crate::Clock, TimerReader: crate::TimerReader + Send + 'static, diff --git a/crates/tracing-instrumentation/src/pretty.rs b/crates/tracing-instrumentation/src/pretty.rs index cf5032ec0d..005c664310 100644 --- a/crates/tracing-instrumentation/src/pretty.rs +++ b/crates/tracing-instrumentation/src/pretty.rs @@ -39,7 +39,7 @@ impl<'a> FmtLevel<'a> { } } -impl<'a> Display for FmtLevel<'a> { +impl Display for FmtLevel<'_> { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { if self.ansi { write!(f, "{}", level_color(self.level).paint(self.level.as_str())) @@ -275,7 +275,7 @@ impl<'a> PrettyVisitor<'a> { } } -impl<'a> field::Visit for PrettyVisitor<'a> { +impl field::Visit for PrettyVisitor<'_> { fn record_str(&mut self, field: &Field, value: &str) { if self.writer.result.is_err() { return; @@ -381,13 +381,13 @@ impl<'a> field::Visit for PrettyVisitor<'a> { } } -impl<'a> VisitOutput for PrettyVisitor<'a> { +impl VisitOutput for PrettyVisitor<'_> { fn finish(self) -> fmt::Result { self.writer.end() } } -impl<'a> VisitFmt for PrettyVisitor<'a> { +impl VisitFmt for PrettyVisitor<'_> { fn writer(&mut self) -> &mut dyn fmt::Write { &mut self.writer.writer } @@ -395,7 +395,7 @@ impl<'a> VisitFmt for PrettyVisitor<'a> { struct ErrorSourceList<'a>(&'a (dyn std::error::Error + 'static)); -impl<'a> Display for ErrorSourceList<'a> { +impl Display for ErrorSourceList<'_> { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { let mut list = f.debug_list(); let mut curr = Some(self.0); @@ -418,7 +418,7 @@ impl<'a> RestateErrorCodeAndDetailsWriter<'a> { } } -impl<'a> field::Visit for RestateErrorCodeAndDetailsWriter<'a> { +impl field::Visit for RestateErrorCodeAndDetailsWriter<'_> { fn record_debug(&mut self, field: &Field, value: &dyn Debug) { if field.name() == RESTATE_ERROR_CODE { self.0.write_padded( @@ -443,7 +443,7 @@ impl<'a> field::Visit for RestateErrorCodeAndDetailsWriter<'a> { } } -impl<'a> VisitOutput for RestateErrorCodeAndDetailsWriter<'a> { +impl VisitOutput for RestateErrorCodeAndDetailsWriter<'_> { fn finish(self) -> fmt::Result { self.0.end() } diff --git a/crates/types/src/logs/builder.rs b/crates/types/src/logs/builder.rs index 30df880302..3fbc253e16 100644 --- a/crates/types/src/logs/builder.rs +++ b/crates/types/src/logs/builder.rs @@ -137,7 +137,7 @@ pub struct ChainBuilder<'a> { modified: &'a mut bool, } -impl<'a> ChainBuilder<'a> { +impl ChainBuilder<'_> { /// Removes and returns whole segments before `until_base_lsn`. /// if `until_base_lsn` falls inside a segment, the segment is kept but all previous /// segments will be dropped. diff --git a/crates/types/src/partition_table.rs b/crates/types/src/partition_table.rs index 535cb2c5c0..f989c5c360 100644 --- a/crates/types/src/partition_table.rs +++ b/crates/types/src/partition_table.rs @@ -548,11 +548,8 @@ impl EqualSizedPartitionPartitioner { ); // adding num_partitions - 1 to dividend is equivalent to applying ceil function to result - let start = - (partition_id * Self::PARTITION_KEY_RANGE_END + (num_partitions - 1)) / num_partitions; - let end = ((partition_id + 1) * Self::PARTITION_KEY_RANGE_END + (num_partitions - 1)) - / num_partitions - - 1; + let start = (partition_id * Self::PARTITION_KEY_RANGE_END).div_ceil(num_partitions); + let end = ((partition_id + 1) * Self::PARTITION_KEY_RANGE_END).div_ceil(num_partitions) - 1; let start = u64::try_from(start) .expect("Resulting partition start '{start}' should be <= u64::MAX."); diff --git a/crates/types/src/replication/nodeset_selector.rs b/crates/types/src/replication/nodeset_selector.rs index 415048bb8d..10ead3af59 100644 --- a/crates/types/src/replication/nodeset_selector.rs +++ b/crates/types/src/replication/nodeset_selector.rs @@ -145,7 +145,7 @@ impl Default for NodeSetSelectorOptions<'_> { } } -impl<'a> NodeSetSelectorOptions<'a> { +impl NodeSetSelectorOptions<'_> { fn hash_node_id(&self, node_id: PlainNodeId) -> u64 { if self.consistent_hashing { let mut hasher = Xxh3::with_seed(self.salt); @@ -536,7 +536,7 @@ impl<'a> OrdDomain<'a> { } } -impl<'a> PartialEq for OrdDomain<'a> { +impl PartialEq for OrdDomain<'_> { fn eq(&self, other: &Self) -> bool { if self.inner.is_top_priority != other.inner.is_top_priority { return false; @@ -549,16 +549,16 @@ impl<'a> PartialEq for OrdDomain<'a> { } } -impl<'a> Eq for OrdDomain<'a> {} +impl Eq for OrdDomain<'_> {} -impl<'a> PartialOrd for OrdDomain<'a> { +impl PartialOrd for OrdDomain<'_> { fn partial_cmp(&self, other: &Self) -> Option { Some(self.cmp(other)) } } // Note that this orders domains in reverse order for min-heap uses -impl<'a> Ord for OrdDomain<'a> { +impl Ord for OrdDomain<'_> { fn cmp(&self, other: &Self) -> Ordering { // Note that this is reverse ordering only for priority and num_writeable_nodes_picked, // but a top-priority domain (a domain with the top-priority node) goes to the top of diff --git a/crates/types/src/retries.rs b/crates/types/src/retries.rs index 4b7db84139..929d61f960 100644 --- a/crates/types/src/retries.rs +++ b/crates/types/src/retries.rs @@ -235,7 +235,7 @@ pub struct RetryIter<'a> { last_retry: Option, } -impl<'a> Iterator for RetryIter<'a> { +impl Iterator for RetryIter<'_> { type Item = Duration; /// adds up to 1/3 target duration as jitter @@ -310,7 +310,7 @@ pub fn with_jitter(duration: Duration, max_multiplier: f32) -> Duration { } } -impl<'a> ExactSizeIterator for RetryIter<'a> {} +impl ExactSizeIterator for RetryIter<'_> {} #[cfg(test)] mod tests { diff --git a/crates/types/src/schema/deployment.rs b/crates/types/src/schema/deployment.rs index ec110b0a92..f6b10f028c 100644 --- a/crates/types/src/schema/deployment.rs +++ b/crates/types/src/schema/deployment.rs @@ -266,7 +266,7 @@ impl DeploymentMetadata { // and for Lambda deployments its the ARN pub fn address_display(&self) -> impl Display + '_ { struct Wrapper<'a>(&'a DeploymentType); - impl<'a> Display for Wrapper<'a> { + impl Display for Wrapper<'_> { fn fmt(&self, f: &mut Formatter) -> fmt::Result { match self { Wrapper(DeploymentType::Http { address, .. }) => address.fmt(f), diff --git a/crates/types/src/schema/invocation_target.rs b/crates/types/src/schema/invocation_target.rs index dcf6e0661d..fca57906f8 100644 --- a/crates/types/src/schema/invocation_target.rs +++ b/crates/types/src/schema/invocation_target.rs @@ -296,7 +296,7 @@ impl InputContentType { fn extract_content_type_parts<'a>( &'a self, input_content_type: &'a str, - ) -> Result<(&str, &str), InputValidationError> { + ) -> Result<(&'a str, &'a str), InputValidationError> { let ct_without_args = input_content_type .split_once(';') .map(|(ct, _)| ct) diff --git a/crates/utoipa/src/openapi.rs b/crates/utoipa/src/openapi.rs index fcbb3e61c1..59748a2528 100644 --- a/crates/utoipa/src/openapi.rs +++ b/crates/utoipa/src/openapi.rs @@ -302,7 +302,7 @@ impl<'de> Deserialize<'de> for OpenApiVersion { { struct VersionVisitor; - impl<'v> Visitor<'v> for VersionVisitor { + impl Visitor<'_> for VersionVisitor { type Value = OpenApiVersion; fn expecting(&self, formatter: &mut Formatter) -> std::fmt::Result { @@ -368,7 +368,7 @@ impl<'de> Deserialize<'de> for Deprecated { D: serde::Deserializer<'de>, { struct BoolVisitor; - impl<'de> Visitor<'de> for BoolVisitor { + impl Visitor<'_> for BoolVisitor { type Value = Deprecated; fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result { @@ -416,7 +416,7 @@ impl<'de> Deserialize<'de> for Required { D: serde::Deserializer<'de>, { struct BoolVisitor; - impl<'de> Visitor<'de> for BoolVisitor { + impl Visitor<'_> for BoolVisitor { type Value = Required; fn expecting(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result { diff --git a/crates/wal-protocol/src/timer.rs b/crates/wal-protocol/src/timer.rs index 6938821d87..fcb76bdaba 100644 --- a/crates/wal-protocol/src/timer.rs +++ b/crates/wal-protocol/src/timer.rs @@ -114,7 +114,7 @@ impl restate_types::timer::Timer for TimerKeyValue { #[derive(Debug)] pub struct TimerKeyDisplay<'a>(pub &'a TimerKey); -impl<'a> fmt::Display for TimerKeyDisplay<'a> { +impl fmt::Display for TimerKeyDisplay<'_> { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { match self.0.kind { TimerKeyKind::NeoInvoke { invocation_uuid } => { diff --git a/crates/worker/src/partition/state_machine/entries/mod.rs b/crates/worker/src/partition/state_machine/entries/mod.rs index 7396be3d7c..099238495c 100644 --- a/crates/worker/src/partition/state_machine/entries/mod.rs +++ b/crates/worker/src/partition/state_machine/entries/mod.rs @@ -384,7 +384,7 @@ struct ApplyJournalCommandEffect<'e, CMD> { completions_to_process: &'e mut VecDeque, } -impl<'e, CMD> ApplyJournalCommandEffect<'e, CMD> { +impl ApplyJournalCommandEffect<'_, CMD> { fn then_apply_completion(&mut self, e: impl Into) { self.completions_to_process .push_back(Entry::from(e.into()).encode::()) diff --git a/crates/worker/src/partition/state_machine/mod.rs b/crates/worker/src/partition/state_machine/mod.rs index fa2e79bac2..8267d37eec 100644 --- a/crates/worker/src/partition/state_machine/mod.rs +++ b/crates/worker/src/partition/state_machine/mod.rs @@ -264,7 +264,7 @@ impl StateMachine { } } -impl<'a, S> StateMachineApplyContext<'a, S> { +impl StateMachineApplyContext<'_, S> { async fn get_invocation_status( &mut self, invocation_id: &InvocationId, @@ -4187,7 +4187,7 @@ impl<'a, S> StateMachineApplyContext<'a, S> { // To write completions in the effects log struct CompletionResultFmt<'a>(&'a CompletionResult); -impl<'a> fmt::Display for CompletionResultFmt<'a> { +impl fmt::Display for CompletionResultFmt<'_> { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { match self.0 { CompletionResult::Empty => write!(f, "Empty"), diff --git a/rust-toolchain.toml b/rust-toolchain.toml index 812fd681ec..c69cc59d29 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,4 +1,4 @@ [toolchain] -channel = "1.82.0" +channel = "1.84.1" profile = "minimal" components = ["rustfmt", "clippy"] diff --git a/tools/mock-service-endpoint/src/handler.rs b/tools/mock-service-endpoint/src/handler.rs index e579442fab..7eb2dfd880 100644 --- a/tools/mock-service-endpoint/src/handler.rs +++ b/tools/mock-service-endpoint/src/handler.rs @@ -383,7 +383,7 @@ fn error(err: FrameError) -> ProtocolMessage { } struct LossyDisplay<'a>(Option<&'a [u8]>); -impl<'a> Display for LossyDisplay<'a> { +impl Display for LossyDisplay<'_> { fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { match self.0 { Some(bytes) => write!(f, "{}", String::from_utf8_lossy(bytes)),