From 1b39bd1b19803d2066f51f3429b0b038cda2dcf1 Mon Sep 17 00:00:00 2001 From: Smit Vora Date: Thu, 22 Aug 2024 16:03:07 +0530 Subject: [PATCH] perf: update values with one db query (cherry picked from commit 6a91ffd9e19cbbc9fe4cded80cfd1a4030a4523e) --- .../v15/update_action_for_gst_inward_supply.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/india_compliance/patches/v15/update_action_for_gst_inward_supply.py b/india_compliance/patches/v15/update_action_for_gst_inward_supply.py index f5928ea0f5..d50d609e09 100644 --- a/india_compliance/patches/v15/update_action_for_gst_inward_supply.py +++ b/india_compliance/patches/v15/update_action_for_gst_inward_supply.py @@ -2,11 +2,10 @@ def execute(): - docs = frappe.get_all( + # Discard the action "Accept Supplier Values" + frappe.db.set_value( "GST Inward Supply", - filters={"action": ["in", ["Accept My Values", "Accept Supplier Values"]]}, - pluck="name", + {"action": ["in", ["Accept My Values", "Accept Supplier Values"]]}, + "action", + "Accept", ) - - for doc in docs: - frappe.db.set_value("GST Inward Supply", doc, "action", "Accept")