Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for uncurried-by-default #755

Open
1 task
zth opened this issue Apr 10, 2023 · 5 comments
Open
1 task

Tracking issue for uncurried-by-default #755

zth opened this issue Apr 10, 2023 · 5 comments

Comments

@zth
Copy link
Collaborator

zth commented Apr 10, 2023

This issue tracks things that needs to be taken care of in the editor tooling to bring the DX of uncurried by default to the same level as the current experience.

  • Pattern completion does not work
@fhammerschmidt
Copy link
Member

#772

@zth
Copy link
Collaborator Author

zth commented Jul 4, 2023

@fhammerschmidt have you noticed more things not working in the extension?

@fhammerschmidt
Copy link
Member

fhammerschmidt commented Jul 4, 2023

The hover info should not use the explicit uncurried notation with the dot when everything is uncurried IMO.

Edit: We just got a new employee and while writing code got easier, the hover info brings some confusion to the table (and is harder to read).

@cristianoc
Copy link
Collaborator

Would you update this issue with some repro, as it states things in absolute terms, which don't apply when you set up aa hello world project.

Screenshot 2023-07-04 at 15 57 09

@fhammerschmidt
Copy link
Member

Ok, the hover thing is not an issue when you set "uncurried": true explicitly.

When creating interface files though, the dots are still there (and the @react.component annotation still gets removed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants