You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed today that we're not actually authenticating the server responses. In handle_401 we call authenticate_user and return the resulting response to the caller, handle_response, which passes it back to the user. Under normal circumstances, we never call handle_other, which is where mutual authentication occurs.
I'm a bad person and I feel bad.
I have a fix in my fork, but I'm not submitting it yet because it breaks tests.
The text was updated successfully, but these errors were encountered:
mkomitee
changed the title
Not authentication server in all cases
Not providing mutual authentication
Aug 8, 2014
I noticed today that we're not actually authenticating the server responses. In
handle_401
we callauthenticate_user
and return the resulting response to the caller,handle_response
, which passes it back to the user. Under normal circumstances, we never callhandle_other
, which is where mutual authentication occurs.I'm a bad person and I feel bad.
I have a fix in my fork, but I'm not submitting it yet because it breaks tests.
The text was updated successfully, but these errors were encountered: