-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gauge concept steps are not properly shown in reports portal UI- It should be ideally shown as a collapsible item #55
Comments
I agree with this, presenting concepts i RP in a similar way to HTML-report would be a great improvement. Was there any investigation into this to see if it's possible? |
It is not yet possible, asked new feature for gauge engine: getgauge/gauge#2450 |
@nvborisenko |
I am almost done with #63 - LOL, 1 year. I really want to do it: performance and file size is sweet. Then I will try reporting of gauge concepts. Before doing it, can you please help me to understand where concepts live. I am looking for all possible ways (beforeScenario/insideScenario/afterFeature), how they look in the final report (html?). |
@jensakejohansson I see that Attaching the entire logs from ReportPortal plugin:
|
@nvborisenko My friend tested this using the Report Portal plugin code. I'll ask him to verify again to make sure we didn't miss anything and then we'll get back to you. Unfortunately that won't be until Thursday of Friday, I have no possibility to look at it since I don't have the dev. env. on my machine at the moment... |
@nvborisenko
Then create a scenario
gauge run specs/example.spec:19 I'm getting the following plugin log: ReportMessagesHandler Information: 0 : 11:38:02.1123105 : 1-ReportPortal.GaugePlugin : NotifyExecutionStarting received
|
@PiotrNestor thank you for confirming. I have the same results. PS: I have the same code in @jensakejohansson please help to fix this issue: Seems we can blame this line: https://github.com/getgauge/gauge/blob/b55b73406d45809228910ae1ee29beaa5a426a20/execution/scenarioExecutor.go#L217 |
It's a question of semantics. Is there need for NotifyConceptExecutionEnding if there is a step failure. ReportMessagesHandler Information: 0 : 12:31:14.4118567 : 1-ReportPortal.GaugePlugin : NotifyExecutionStarting received |
I would say it is a question of consistency. For steps execution we are getting |
OK. I see your point :) Also there is a case where this is a real issue. |
@nvborisenko Can you verify the proposed update with your gauge build? Also, are there any other issues? 'execution/scenarioExecutor.go' in 'executeConcept' method
|
I will be able to check if you can provide built binaries (win x64). Thanks in advance. |
Only the gauge.exe is relevant https://github.com/system-verification/gauge/releases/tag/gauge_pre_1.6.1 |
Perfect. I am getting proper events. The next step is to understand whether I can determine relations between scenarios/concepts/steps. |
In the gauge runner update the concept data is sent in the ExecutionInfo in the same format as a scenario step. In other words after NotifyConceptExecutionStarting there is:
|
@PiotrNestor I think we are good, feel free to propose your fix for the gauge. Thank you for support. |
@nvborisenko
|
I am working in As soon as gauge releases your fix, we can publish a release supporting concepts reporting. |
I think the fix is in 1.6.1. Is that the version you're using? |
This is released: gauge (1.6.1) |
Ah, they already released it. So working on releasing new plugin version. |
Available in v1.16.0 https://github.com/reportportal/agent-net-gauge/releases/tag/1.16.0. |
@nvborisenko But there are some table related presentation issues. Note that this is rather cosmetic though ...
The concept definition is:
In the output:
|
Fixed in |
@nvborisenko |
Thx for confirming, new round of patches :) |
Gauge has a functionality of concepts: so in a concept file you can have multiple gauge steps, and when you call a concept header (Also a part of concept file) as a step in spec file:
More details are mentioned here:
In Gauge HTML report : Concepts are shown as collapsible item, where in by default everything is collapsed and only concept header is shown : you can expand the header to show the internal steps concept is using
But when same HTML reports are uploaded to report portal, all internal steps of concepts are shown by defualt, which makes reports a bit lengthy : It would be great if you could provide support of concepts as well. We and probably many others uses concepts functionality of gauge quite extensively.
Also thank you for creating such a cool Project, and supporting so many different types of plugins.
Attaching a sample gauge HTML report of a spec using concepts, as a reference:
html-report.zip
Please let me know if you need any more information regarding this topic.
The text was updated successfully, but these errors were encountered: