Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullability annotation for primitive setters #361

Closed
pronebird opened this issue Feb 5, 2017 · 2 comments
Closed

Add nullability annotation for primitive setters #361

pronebird opened this issue Feb 5, 2017 · 2 comments

Comments

@pronebird
Copy link

pronebird commented Feb 5, 2017

Feature Request

Nullability annotations are not added for primitive setters, i.e.:

@property (nonatomic, strong, nullable) Foo *foo;

- (void)setPrimitiveIncome:(Foo*)value;

Expected Behavior

Primitive setter should be generated with nullability annotation.

- (void)setPrimitiveFoo:(__nullable Foo*)value;

Actual Behavior

Nullability annotation is not being added to method declaration.

- (void)setPrimitiveIncome:(Foo*)value;

Additional Information

Mogenerator v1.31

@mbabin
Copy link
Contributor

mbabin commented Mar 5, 2017

More specifically, I believe nullability annotation is not added for primitive accessors of optional, to-one relationships, leading to a mismatch with the corresponding property accessors.

@atomicbird
Copy link
Collaborator

This was fixed in #363, which has just been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants