From 2e0ffb82ee3f74643b514ca3f9e576e8a97296c2 Mon Sep 17 00:00:00 2001 From: Rhys Arkins Date: Thu, 4 May 2023 12:22:12 +0200 Subject: [PATCH 1/3] feat(npm)!: disable rollbackPrs for npm by default --- lib/modules/manager/npm/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/modules/manager/npm/index.ts b/lib/modules/manager/npm/index.ts index 3ac8a7f281b4ea..9d309bd8a23348 100644 --- a/lib/modules/manager/npm/index.ts +++ b/lib/modules/manager/npm/index.ts @@ -17,7 +17,6 @@ export const supportsLockFileMaintenance = true; export const defaultConfig = { fileMatch: ['(^|/)package\\.json$'], - rollbackPrs: true, versioning: npmVersioning.id, digest: { prBodyDefinitions: { From f63a6c91d0e347877600d77cc8268ab7505e51f2 Mon Sep 17 00:00:00 2001 From: Rhys Arkins Date: Thu, 4 May 2023 15:17:22 +0200 Subject: [PATCH 2/3] fix test --- lib/config/index.spec.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/config/index.spec.ts b/lib/config/index.spec.ts index 41deb82830f776..4ee10a5851cc63 100644 --- a/lib/config/index.spec.ts +++ b/lib/config/index.spec.ts @@ -96,7 +96,6 @@ describe('config/index', () => { const config = configParser.getManagerConfig(parentConfig, 'npm'); expect(config).toContainEntries([ ['fileMatch', ['(^|/)package\\.json$']], - ['rollbackPrs', true], ]); expect( configParser.getManagerConfig(parentConfig, 'html') From 696c0e24f68c00b00152b7547d65befe5533eb3c Mon Sep 17 00:00:00 2001 From: Rhys Arkins Date: Fri, 5 May 2023 08:12:12 +0200 Subject: [PATCH 3/3] docs --- docs/usage/configuration-options.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/usage/configuration-options.md b/docs/usage/configuration-options.md index ea047bcc7c4346..a37b6e548b5d70 100644 --- a/docs/usage/configuration-options.md +++ b/docs/usage/configuration-options.md @@ -3192,9 +3192,8 @@ There are times when a dependency version in use by a project gets removed from For some registries, existing releases or even whole packages can be removed or "yanked" at any time, while for some registries only very new or unused releases can be removed. Renovate's "rollback" feature exists to propose a downgrade to the next-highest release if the current release is no longer found in the registry. -Renovate does not create these rollback PRs by default, with one exception: npm packages get a rollback PR if needed. - -You can configure the `rollbackPrs` property globally, per-language, or per-package to override the default behavior. +Renovate does not create these rollback PRs by default, so this functionality needs to be opted-into. +We recommend you do this selectively with `packageRules` and not globally. ## ruby