Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go mod update from v1 to v2 results in incorrect double version suffix in URL #8562

Closed
ViRb3 opened this issue Feb 6, 2021 · 4 comments · Fixed by #8946
Closed

Go mod update from v1 to v2 results in incorrect double version suffix in URL #8562

ViRb3 opened this issue Feb 6, 2021 · 4 comments · Fixed by #8946
Labels
manager:gomod Go Modules priority-2-high Bugs impacting wide number of users or very important features status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality

Comments

@ViRb3
Copy link

ViRb3 commented Feb 6, 2021

What Renovate type, platform and version are you using?

Test A

  • Self-hosted Renovate 24.38.4
  • Gitea 1.13.2

Test B

  • Public Renovate Github Bot

Describe the bug

I have a Go module repo that, in its Go.mod file, references:

github.com/gofiber/fiber v1.14.6

The latest version of fiber is v2.4.1. When Renovate sends a PR, it looks like this:

github.com/gofiber/fiber/v2/v2@v2.4.1

Notice the double /v2/v2 suffix. This is wrong, and the PR fails. It should be just one /v2 instead.

Relevant debug logs

Command failed: docker run --rm --name=renovate_go --label=renovate_child -v "/mnt/renovate/gh/ViRb3/renovate-bug-mrr":"/mnt/renovate/gh/ViRb3/renovate-bug-mrr" -v "/tmp/renovate-cache":"/tmp/renovate-cache" -v "/tmp/renovate-cache/others/go":"/tmp/renovate-cache/others/go" -e GOPATH -e CGO_ENABLED -w "/mnt/renovate/gh/ViRb3/renovate-bug-mrr" docker.io/renovate/go:1.15.8 bash -l -c "git config --global url.\"https://**redacted**@github.com/\".insteadOf \"https://github.com/\" && go get -d ./..."

Have you created a minimal reproduction repository?

Yes. It can be found here and the bad PR is here.

@HonkingGoose HonkingGoose added manager:gomod Go Modules priority-2-high Bugs impacting wide number of users or very important features reproduction:provided status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Feb 6, 2021
@sluongng
Copy link
Contributor

sluongng commented Feb 6, 2021

Same with #8525

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 24.73.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ViRb3
Copy link
Author

ViRb3 commented Mar 14, 2021

@rarkins I just received a PR from the Renovate bot with a rather strange change:

https://github.com/ViRb3/renovate-bug-mrr/pull/4/files

-require github.com/gofiber/fiber v1.14.6
+require (
+	github.com/gofiber/fiber v1.14.6
+	github.com/gofiber/fiber/v2 v2.6.0
+)

v2 should have replaced v1 in the requires. Is this a regression?

@rarkins
Copy link
Collaborator

rarkins commented Mar 14, 2021

Please file a fresh bug report and we'll decide if we need to roll it back. Looks like go added back v1 after Renovate changed it directly

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:gomod Go Modules priority-2-high Bugs impacting wide number of users or very important features status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants