Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise for lerna@3 directory structure #2389

Closed
rarkins opened this issue Aug 15, 2018 · 1 comment
Closed

Optimise for lerna@3 directory structure #2389

rarkins opened this issue Aug 15, 2018 · 1 comment
Labels
manager:npm package.json files (npm/yarn/pnpm) priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Aug 15, 2018

lerna@3 encourages file: relative references for npm users, like here: https://github.com/zillow/javascript/blob/latest/package.json

It seems to remove the need for lerna bootstrap.
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:npm package.json files (npm/yarn/pnpm) labels Aug 15, 2018
@rarkins
Copy link
Collaborator Author

rarkins commented Aug 16, 2018

It seems that running lerna bootstrap is harmless though, so this is low priority.

@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Aug 16, 2018
@rarkins rarkins changed the title Support lerna@3 directory structure Optimise for lerna@3 directory structure Aug 16, 2018
@mcous mcous mentioned this issue Mar 23, 2019
Closed
@rarkins rarkins added the status:requirements Full requirements are not yet known, so implementation should not be started label Jan 12, 2021
@rarkins rarkins closed this as completed Aug 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
manager:npm package.json files (npm/yarn/pnpm) priority-4-low Low priority, unlikely to be done unless it becomes important to more people status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rarkins