From 545bf31bc00f9661db8cd9c511fc862feaa24ab4 Mon Sep 17 00:00:00 2001 From: alsyia Date: Thu, 30 Jan 2025 17:01:12 +0100 Subject: [PATCH] fix(presets): match on devDependencies or dev for dev dependencies-related presets (#33909) Co-authored-by: Rhys Arkins --- lib/config/presets/__snapshots__/index.spec.ts.snap | 4 +++- lib/config/presets/internal/default.ts | 12 ++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/config/presets/__snapshots__/index.spec.ts.snap b/lib/config/presets/__snapshots__/index.spec.ts.snap index bd3fea422a76f5..ce57b9dfbee0c6 100644 --- a/lib/config/presets/__snapshots__/index.spec.ts.snap +++ b/lib/config/presets/__snapshots__/index.spec.ts.snap @@ -34,7 +34,7 @@ exports[`config/presets/index resolvePreset migrates automerge in presets 1`] = "Add the \`renovate/\` prefix to all branch names.", "Use semantic commit type \`fix\` for dependencies and \`chore\` for all others if semantic commits are in use.", "Require all status checks to pass before any automerging.", - "Pin dependency versions for \`devDependencies\` and retain SemVer ranges for others.", + "Pin dependency versions for development dependencies and retain SemVer ranges for others.", ], "ignoreTests": false, "ignoreUnstable": true, @@ -111,6 +111,8 @@ exports[`config/presets/index resolvePreset migrates automerge in presets 1`] = { "matchDepTypes": [ "devDependencies", + "dev-dependencies", + "dev", ], "rangeStrategy": "pin", }, diff --git a/lib/config/presets/internal/default.ts b/lib/config/presets/internal/default.ts index a2ab86a2c3c799..e567f1168e15e3 100644 --- a/lib/config/presets/internal/default.ts +++ b/lib/config/presets/internal/default.ts @@ -141,11 +141,11 @@ export const presets: Record = { description: 'Disable Renovate Dependency Dashboard creation.', }, disableDevDependencies: { - description: 'Do not update `devDependencies` versions/ranges.', + description: 'Do not update development dependencies.', packageRules: [ { enabled: false, - matchDepTypes: ['devDependencies'], + matchDepTypes: ['devDependencies', 'dev-dependencies', 'dev'], }, ], }, @@ -408,10 +408,10 @@ export const presets: Record = { ], }, pinDevDependencies: { - description: 'Pin dependency versions for `devDependencies`.', + description: 'Pin dependency versions for development dependencies.', packageRules: [ { - matchDepTypes: ['devDependencies'], + matchDepTypes: ['devDependencies', 'dev-dependencies', 'dev'], rangeStrategy: 'pin', }, ], @@ -422,14 +422,14 @@ export const presets: Record = { }, pinOnlyDevDependencies: { description: - 'Pin dependency versions for `devDependencies` and retain SemVer ranges for others.', + 'Pin dependency versions for development dependencies and retain SemVer ranges for others.', packageRules: [ { matchPackageNames: ['*'], rangeStrategy: 'replace', }, { - matchDepTypes: ['devDependencies'], + matchDepTypes: ['devDependencies', 'dev-dependencies', 'dev'], rangeStrategy: 'pin', }, {