Deprecated for the dependancy rollup-plugin-node-polyfills warning to use @rollup/plugin-inject.

[mrbm]

@esbuild-plugins/node-modules-polyfill is using the dependancy rollup-plugin-node-polyfills which gives the warning that rollup-plugin-node-polyfills is depreciated and should use @rollup/plugin-inject.

Is that by design or just an oversight?

Thanks!

[shellscape]

Probably a bit of both, as the node-builtins aspect of bundling is hard to maintain and error-prone. This project should use an alternative: https://www.npmjs.com/search?ranking=maintenance&q=rollup%20node

rollup-plugin-inject has been deprecated for 3 years. rollup-plugin-node-polyfills is 4 years out of date.

[mrienstra]

Note that the README for this repo says (lines 15 & 16):

• @esbuild-plugins/node-modules-polyfill (out of date, use esbuild-plugin-polyfill-node for up to date polyfills)
• @esbuild-plugins/node-globals-polyfill (out of date, use esbuild-plugin-polyfill-node for up to date polyfills)

... so although there is no formal deprecation notice, I wouldn't hold your breath.

On a related note, just ran across this in cloudflare/workers-sdk#3832:

The esbuild-plugins repo itself points towards using esbuild-plugin-polyfill-node instead https://github.com/remorses/esbuild-plugins/blob/373b449/README.md?plain=1#L15-L16 [...]

After doing this in the Remix repo (see remix-run/remix#5274), we got quite some new bugs, so we chose to go for @imranbarbhuiya's esbuild-plugins-node-modules-polyfill instead (see remix-run/remix#6562), which is an up-to-date and well maintained alternative

If you look at the "This was referenced" list at the bottom of remix-run/remix#6562, you can see how a few different repos reacted to a proposed move from @esbuild-plugins/node-modules-polyfill to esbuild-plugins-node-modules-polyfill.