Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: useSubmitImpl() not respects incoming query search when using POST #927

Closed
jacargentina opened this issue Dec 6, 2021 · 2 comments · Fixed by #3697
Closed

[Bug]: useSubmitImpl() not respects incoming query search when using POST #927

jacargentina opened this issue Dec 6, 2021 · 2 comments · Fixed by #3697
Labels
bug Something isn't working renderer:react

Comments

@jacargentina
Copy link
Contributor

jacargentina commented Dec 6, 2021

What version of Remix are you using?

1.0.6

What version of Node are you using? Minimum supported version is 14.

17.0.1

Steps to Reproduce

  • routes/myform.tsx which is navigated like this http://localhost:3000/myform?returnUrl=/blog
  • myform.tsx calls submit({values: ...}, {method: 'post'})
  • myform.tsx action simply returns null
  • URL now is missing the returnUrl=/blog query string

Expected Behavior

URL should remain unchanged and maintain its query string

Actual Behavior

URL only points to the plain route, without any query string

@machour
Copy link
Collaborator

machour commented Apr 12, 2022

Tracked in #931

@mcansh
Copy link
Collaborator

mcansh commented Aug 16, 2022

🤖 Hello there,

We just published version v1.6.8 which includes a fix for this. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working renderer:react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants