Remix v1.16.0 - Unable to build app with crypto dependency

[nggonzalez]

What version of Remix are you using?

v1.16.0

Are all your remix dependencies & dev-dependencies using the same version?

• Yes

Steps to Reproduce

1. Create an app with import { createHash } from "crypto".
2. Build the app

Expected Behavior

Should build successful - behavior in 1.15.0

Actual Behavior

Fails to build

✘ [ERROR] No matching export in "node_modules/@remix-run/dev/node_modules/esbuild-plugin-polyfill-node/polyfills/empty.js" for import "createHash"

    node_modules/@taskforcesh/bullmq-pro/node_modules/bullmq/dist/esm/classes/repeat.js:3:9:
      3 │ import { createHash } from 'crypto';

[SleeplessByte]

Happens for all imports from crypto. It seems that remix is trying to "polyfill" them, but the polyfill for that package doesn't exist.

[nggonzalez]

Updated the title to make that clear.

I think the compiler config likely changed between v1.15.0 and v1.16.0.

[pcattori]

Probably related to #5274 and #6259

[tmcw]

This also causes issues with importing the TypeScript "ts" package from frontend code - the injected polyfills make the browser environment look enough like Node that TypeScript tries to run in Node with FS access. It'd be great to avoid Node polyfills altogether in the web builds.

[MichaelDeBoey]

We just published version 1.17.1-pre.0 which includes #6562 (a possible fix). If you'd like to take it for a test run please try it out and let us know what you think!

[fiws]

I think 1.17.1-pre.0 almost works, but it still fails if we try to import randomUUID.

✘ [ERROR] No matching export in "node-modules-polyfills:crypto" for import "randomUUID"

[marcfalk]

I think 1.17.1-pre.0 almost works, but it still fails if we try to import randomUUID.

✘ [ERROR] No matching export in "node-modules-polyfills:crypto" for import "randomUUID"

@MichaelDeBoey Can confirm that the error still throws. I'm using Remix 1.17.1-pre.0 and @defer/client@1.4.0, which relies on randomUUID from crypto.

[imranbarbhuiya]

I think 1.17.1-pre.0 almost works, but it still fails if we try to import randomUUID.

✘ [ERROR] No matching export in "node-modules-polyfills:crypto" for import "randomUUID"

@MichaelDeBoey Can confirm that the error still throws. I'm using Remix 1.17.1-pre.0 and @defer/client@1.4.0, which relies on randomUUID from crypto.

defer-run/defer.client#60 (comment)

[luisgrisolia]

Changing to a namespace import fixed the issue
import * as crypto from "crypto";
let random_uuid = crypto.randomUUID()

Package:
"@remix-run/dev": "^1.18.1"

[markdalgleish]

I've confirmed that import { createHash } from "crypto" works in the latest version of Remix.

As @luisgrisolia mentioned, you may have to use import * if you're using an export that isn't polyfilled in the client build.