Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitive Dependency Using Long-Deprecated Rollup Plugin #6144

Closed
1 task done
shellscape opened this issue Apr 23, 2023 · 2 comments
Closed
1 task done

Transitive Dependency Using Long-Deprecated Rollup Plugin #6144

shellscape opened this issue Apr 23, 2023 · 2 comments

Comments

@shellscape
Copy link

What version of Remix are you using?

1.15.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

Hey folks. Just stopping by to let you know that the css package is using a rollup plugin by way of a transitive dependency, which has been deprecated for more than 3 years, technically relies on a very old version of Rollup, and hasn't received any updates in as long.

→ pnpm why rollup-plugin-inject
Legend: production dependency, optional only, dev only

dependencies:
@remix-run/css-bundle 1.15.0
└─┬ @remix-run/dev 1.15.0
  └─┬ @esbuild-plugins/node-modules-polyfill 0.1.4
    └─┬ rollup-plugin-node-polyfills 0.2.1
      └── rollup-plugin-inject 3.0.2

rollup-plugin-node-polyfills has been stale for 4 years

rollup-plugin-inject has been stale and deprecated for 3 years

It might be worthwhile to fork https://github.com/remorses/esbuild-plugins to maintain the plugin you're using there, or roll your own using one of the more updated community node-builtins alternatives https://www.npmjs.com/search?ranking=maintenance&q=rollup%20node

I come to you as the rollup plugins lead maintainer, so I hope you'll take this report in earnest.

Expected Behavior

n/a

Actual Behavior

n/a

@MichaelDeBoey
Copy link
Member

We switched to using esbuild-plugin-polyfill-node in #5274, so you won't see the deprecation warnings once we release the next version

@shellscape
Copy link
Author

Bueno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants