-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade esbuild to v0.15.13+ #4788
Comments
Made some progress on this today. The compiler builds normally, but when the CLI calls Made an issue for |
Confirmed that this is a bug introduced in esbuild 0.15.13: evanw/esbuild#2485 (comment) |
esbuild 0.16.3 should fix this: https://github.com/evanw/esbuild/releases/tag/v0.16.3 |
Progress
Related issues
satisfies
in combination withLoaderFunction
#4675Context
Upgrading to
esbuild
v0.15.13 or newer is causing our integration tests to hang indefinitely.This happens only when our compiler is run via
spawn
ed process.@mcansh and @pcattori have looked into this and narrowed the problem down to the browser build.
We were able to reproduce the tests hanging locally and then saw that changing the browser build to be non-incremental fix the issue. However, this did not fix the issue in CI.
I was able to also reproduce the issue outside of tests by writing a simple script that used
cross-spawn
and/orexeca
to runremix build
from within a child process.We need to dig a bit more to see if this is a bug in one of our esbuild plugins or something else.
The text was updated successfully, but these errors were encountered: