From 4b6ecafb57e3543f780613f940f03ef4840eed34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C3=ABl=20De=20Boey?= <info@michaeldeboey.be>
Date: Thu, 16 Mar 2023 21:28:35 +0100
Subject: [PATCH] feat!(remix-dev): remove `browserBuildDirectory` config
 (#5701)

---
 .changeset/silver-readers-think.md |  5 +++++
 packages/remix-dev/config.ts       | 20 +-------------------
 2 files changed, 6 insertions(+), 19 deletions(-)
 create mode 100644 .changeset/silver-readers-think.md

diff --git a/.changeset/silver-readers-think.md b/.changeset/silver-readers-think.md
new file mode 100644
index 00000000000..b529f441942
--- /dev/null
+++ b/.changeset/silver-readers-think.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/dev": major
+---
+
+remove `browserBuildDirectory` config
diff --git a/packages/remix-dev/config.ts b/packages/remix-dev/config.ts
index 3b52c1c9c42..ebf28f4c87c 100644
--- a/packages/remix-dev/config.ts
+++ b/packages/remix-dev/config.ts
@@ -79,14 +79,6 @@ export interface AppConfig {
    */
   assetsBuildDirectory?: string;
 
-  /**
-   * The path to the browser build, relative to remix.config.js. Defaults to
-   * "public/build".
-   *
-   * @deprecated Use `{@link AppConfig.assetsBuildDirectory}` instead
-   */
-  browserBuildDirectory?: string;
-
   /**
    * The URL prefix of the browser build with a trailing slash. Defaults to
    * `"/build/"`. This is the path the browser will use to find assets.
@@ -489,14 +481,8 @@ export async function readConfig(
     ? path.resolve(appDirectory, userEntryServerFile)
     : path.resolve(defaultsDirectory, entryServerFile);
 
-  if (appConfig.browserBuildDirectory) {
-    warnOnce(browserBuildDirectoryWarning, "browserBuildDirectory");
-  }
-
   let assetsBuildDirectory =
-    appConfig.assetsBuildDirectory ||
-    appConfig.browserBuildDirectory ||
-    path.join("public", "build");
+    appConfig.assetsBuildDirectory || path.join("public", "build");
 
   let absoluteAssetsBuildDirectory = path.resolve(
     rootDirectory,
@@ -676,10 +662,6 @@ let listFormat = new Intl.ListFormat("en", {
   type: "conjunction",
 });
 
-export let browserBuildDirectoryWarning =
-  "⚠️ DEPRECATED: The `browserBuildDirectory` config option is deprecated. " +
-  "Use `assetsBuildDirectory` instead.";
-
 export let serverBuildDirectoryWarning =
   "⚠️ DEPRECATED: The `serverBuildDirectory` config option is deprecated. " +
   "Use `serverBuildPath` instead.";