Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading indicator to top nav #163

Closed
brookslybrand opened this issue Jan 26, 2024 · 6 comments
Closed

Add loading indicator to top nav #163

brookslybrand opened this issue Jan 26, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@brookslybrand
Copy link
Contributor

A suggestion from @brophdawg11

we should add some form of loading indicators to the top nav (Docs, Blog, Showcase, Resources). I clicked on one that didn't have a cache entry so it took ~1-2s and there's no visual feedback that my click did anything

@brookslybrand brookslybrand added enhancement New feature or request good first issue Good for newcomers labels Jan 26, 2024
@sergiodxa
Copy link
Member

@brookslybrand have you considered nProgress? It's super simple but it's also similar to what some browsers like Safari shows when doing a MPA transition.

@brookslybrand
Copy link
Contributor Author

@sergiodxa I have not really considered much of anything, just wanted to capture this comment real quick when Matt brought it up. That definitely looks like it could be a good option 👍

@gustavoguichard
Copy link
Contributor

gustavoguichard commented Feb 1, 2024

Would you be willing to have a Github-like progress bar like the one on this post as a start?
I can work on this PR if desirable.

@brookslybrand
Copy link
Contributor Author

@gustavoguichard sure! I think that's pretty similar to what Sergio recommended. I'd love a PR (even if just as a POC) 🙏

@gustavoguichard
Copy link
Contributor

I'll send it this weekend ;)

@stephenwade
Copy link

I think this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants