Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remark plugins are not working #41

Closed
4 tasks done
ChristopherPAndrews opened this issue Jan 19, 2022 · 4 comments
Closed
4 tasks done

Remark plugins are not working #41

ChristopherPAndrews opened this issue Jan 19, 2022 · 4 comments
Labels
🙋 no/question This does not need any changes

Comments

@ChristopherPAndrews
Copy link

Initial checklist

Affected packages and versions

react-remark 2.1.0 and remark-gfm 3.0.1

Link to runnable example

https://stackblitz.com/edit/react-ts-zf4r6n?file=index.tsx

Steps to reproduce

The linked code shows the problem. When I add a remark plugin (in this instance remark-gfm, but I also tried remark-math), there is no output and no errors.

I also tried this using the hook version and got null as the rendered content.

If I dial back the version of remark-gfm to 1.0 as it is in this project's package.json, then it works as expected.

Expected behavior

I expected the markdown to be converted to HTML and the table in github flavored markdown to be correctly rendered.

Actual behavior

Nothing is output at all, and there are no warning or error messages in the console.

Runtime

No response

Package manager

No response

OS

No response

Build and bundle tools

No response

@ChristianMurphy
Copy link
Member

React-remark is currently using remark 13, meaning remark plugins need to be remark 13 compatible.
For example remark-gfm 1 is remark 13 compatible: https://stackblitz.com/edit/react-ts-vv9vh1?file=index.tsx

The next major release will support remark 14, and newer versions of remark-gfm #39

@ChristianMurphy ChristianMurphy added the 🙋 no/question This does not need any changes label Jan 19, 2022
@ChristianMurphy
Copy link
Member

Nothing is output at all, and there are no warning or error messages in the console

This is a bit annoying, but not something react-remark itself can fix.
Managing version compatibility between plugins in remark is something which could be done in remark/unified, but thus far has opted to be documentation based.

@ChristianMurphy ChristianMurphy mentioned this issue May 11, 2022
4 tasks
@newtmex
Copy link

newtmex commented May 12, 2022

HI @ChristianMurphy Nice plugin you made here.

Any ETA for the next major release that will support remark 14?

@ChristianMurphy
Copy link
Member

No ETA currently, will probably be a couple months until I can circle back and start to look into the remaining migration items again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 no/question This does not need any changes
Development

No branches or pull requests

3 participants