Use pushitem content to upload #324
Merged
+14
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f53093 to
cf62a09
Compare
cf62a09 to
b69f197
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 54 54
Lines 3017 3017
=========================================
Hits 3017 3017 ☔ View full report in Codecov by Sentry. |
|
Not a big deal, but technically |
pushitem content method returns a file-like object with the item bits that may be used for upload. This decouples the source of the items and expectation to exist as a file on local fs
b69f197 to
20b0e62
Compare
rohanpm
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushitem content method added in latest pushsource update returns a file-like object with the item bits that may be used for upload. This decouples the source of the items and expectation to exist as a file on local fs.
Note: This PR will be applicable after the changes to
pushsourceare mergedrelease-engineering/pushsource#643