-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check related images parameter to Add request #64
Add check related images parameter to Add request #64
Conversation
@xDaile , the IIB PR is merged now, could you please address my comment, remove the [Draft] from this MR and then merge this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test with check_related_images set to False or None
b659de0
b659de0
to
548b59a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 5 5
Lines 286 288 +2
=======================================
+ Hits 285 287 +2
Misses 1 1
☔ View full report in Codecov by Sentry. |
Related Issue: CLOUDDST-19796
As the
check_related_images
parameter is added to the IIB (PR: Add related_images check in IIB ), we need to update iiblib accordingly.The parameter "check_related_images" was added to the iiblib AddModel, and tests were updated.