Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check related images parameter to Add request #64

Merged

Conversation

xDaile
Copy link
Contributor

@xDaile xDaile commented Aug 9, 2023

Related Issue: CLOUDDST-19796

As the check_related_images parameter is added to the IIB (PR: Add related_images check in IIB ), we need to update iiblib accordingly.

The parameter "check_related_images" was added to the iiblib AddModel, and tests were updated.

@chandwanitulsi
Copy link

chandwanitulsi commented Aug 23, 2023

@xDaile , the IIB PR is merged now, could you please address my comment, remove the [Draft] from this MR and then merge this PR?
Also a reminder, one approval from the Code owners is needed to merge this PR

midnightercz
midnightercz previously approved these changes Aug 24, 2023
@xDaile xDaile changed the title [Draft] Add check related images parameter to Add request Add check related images parameter to Add request Aug 24, 2023
Copy link

@chandwanitulsi chandwanitulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test with check_related_images set to False or None

@xDaile xDaile force-pushed the add_check_related_images_parameter branch from b659de0 to 548b59a Compare August 24, 2023 14:07
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6c8cbec) 99.65% compared to head (2b8b68d) 99.65%.

❗ Current head 2b8b68d differs from pull request most recent head 548b59a. Consider uploading reports for the commit 548b59a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files           5        5           
  Lines         286      288    +2     
=======================================
+ Hits          285      287    +2     
  Misses          1        1           
Files Changed Coverage Δ
iiblib/iib_build_details_model.py 100.00% <ø> (ø)
iiblib/iib_client.py 99.23% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lipoja lipoja merged commit 0497107 into release-engineering:master Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants