Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IIB uses opm render #784

Merged
merged 3 commits into from
Feb 5, 2025
Merged

IIB uses opm render #784

merged 3 commits into from
Feb 5, 2025

Conversation

lipoja
Copy link
Contributor

@lipoja lipoja commented Jan 23, 2025

We agreed to drop opm serve command and move to opm render instead.
This PR adds opm render and removes unused parts of code with opm serve.

[CLOUDDST-25207]

JAVGan
JAVGan reviewed Jan 23, 2025
View reviewed changes
@xDaile
Copy link
Contributor

xDaile commented Jan 28, 2025

Small comment, otherwise LGTM.

xDaile
xDaile reviewed Jan 28, 2025
View reviewed changes
yashvardhannanavati
yashvardhannanavati requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@yashvardhannanavati yashvardhannanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. Looks good otherwise!

@lipoja lipoja force-pushed the opm_render branch 5 times, most recently from bcde8ab to adfbb53 Compare January 29, 2025 11:53
yashvardhannanavati
yashvardhannanavati previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@yashvardhannanavati yashvardhannanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't get a chance to test it locally. Code wise looks good!

xDaile
xDaile previously approved these changes Jan 30, 2025
View reviewed changes
chandwanitulsi
chandwanitulsi reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@chandwanitulsi chandwanitulsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise looks good

JAVGan
JAVGan previously approved these changes Jan 30, 2025
View reviewed changes
@lipoja lipoja dismissed stale reviews from JAVGan, xDaile, and yashvardhannanavati via 564f2f3 February 3, 2025 12:25
@lipoja lipoja merged commit bcfce93 into release-engineering:master Feb 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAVGan JAVGan JAVGan approved these changes

@chandwanitulsi chandwanitulsi chandwanitulsi approved these changes

@yashvardhannanavati yashvardhannanavati yashvardhannanavati left review comments

@xDaile xDaile xDaile left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lipoja @xDaile @JAVGan @chandwanitulsi @yashvardhannanavati