Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-deprecation worker implementation #713

Conversation

chandwanitulsi
Copy link
Contributor

No description provided.

@chandwanitulsi chandwanitulsi force-pushed the add-deprecation-worker branch 3 times, most recently from f89191e to 32ca804 Compare August 28, 2024 18:32
Copy link
Collaborator

@yashvardhannanavati yashvardhannanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments, otherwise looks great!

@chandwanitulsi chandwanitulsi force-pushed the add-deprecation-worker branch 2 times, most recently from debb9e4 to b615ec7 Compare October 10, 2024 17:46
Copy link
Collaborator

@yashvardhannanavati yashvardhannanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Apologies, I missed it earlier. Otherwise, LGTM!

@yashvardhannanavati
Copy link
Collaborator

@chandwanitulsi could you please rebase your branch?

@chandwanitulsi chandwanitulsi merged commit 1ed99de into release-engineering:master Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants