Fix bug with FBC YAML Operators

[JAVGan]

When an operator has catalog in yaml insted of json, some requests (like add) fails on "duplicate package" as merge_catalogs_dirs function generates FBC from hidden index.db created as json files and then copy over its content to final location where are all yaml files.

To prevent this issue this simple fix will walk through the config directory and convert any YAML files into JSON to ensure that everything uses the same format in the index image.

Refers to CLOUDDST-21432

[JAVGan]

@release-engineering/exd-guild-hello-operator PTAL.

I took the liberty to convert all files in the config dir to JSON as it's the default one from opm, having the solution "supporting" YAML in input but always outputting in JSON. Please let me know whether it's OK to go with this.

[lipoja]

@JAVGan I have to think about this solution - tomorrow.
My assumption was that the error was caused by opm migrate where we we generated json but copied it over to /config dir so it ended up with two files (yaml, json) for one operator and then everything crashed when we were generating cache.

My idea was to detect what format is on the input as a source_image. Then use opm migrate -o yaml or json.
This would work for our use-case - bootstrapping - with empty target_image.

[JAVGan]

My idea was to detect what format is on the input as a source_image. Then use opm migrate -o yaml or json.
This would work for our use-case - bootstrapping - with empty target_image.

@lipoja I was thinking about this, but what would happen if we receive multiple operators (to add, for example) being one of them, say, JSON and the rest YAML? Or vice-versa? That's why I thought on streamlining everything, but sure, we can discuss this tomorrow.

[yashvardhannanavati]

My idea was to detect what format is on the input as a source_image. Then use opm migrate -o yaml or json.
This would work for our use-case - bootstrapping - with empty target_image.

@lipoja I was thinking about this, but what would happen if we receive multiple operators (to add, for example) being one of them, say, JSON and the rest YAML? Or vice-versa? That's why I thought on streamlining everything, but sure, we can discuss this tomorrow.

Yeah, I think agree with Jonathan's reasoning here since we are supporting adding multiple operators in a single fragment.

[lipoja]

Yeah I know what you mean. I thought we could go with opm generating the output. The reason behind that is that opm is "consuming" those files so it would not generate anything that is faulty.
If we go this way I think we should validate the output -to be sure everything is correct and opm can load it.
opm validate might help us - in my opinion we should use this before every build.

[JAVGan]

Rebased

[xDaile]

I agree to changes, however I IMO do not have enough expertise to approve this.

[JAVGan]

@lipoja @chandwanitulsi @yashvardhannanavati I've rebased and fixed the conflicts, please give a final review so I can merge it