Log a warning message when "architecture" label is missing under "Labels" #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDaile
reviewed
Aug 16, 2023
chandwanitulsi
previously approved these changes
Aug 16, 2023
…els" When using an Openshift binary as the binary_image, the "architecture" label is added under the "Labels" section on an index image. This is done for the OCP cluster to recognize the arch of the image. This is an OCP specific thing and it's not necessary that the "architecture" label will be added under "Labels" if a user specifies any other binary_image. Hence, in-case the label is missing from the index, do not fail the request. Refers to CLOUDDST-19860
d4e7c67 to
940570a
Compare
xDaile
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an Openshift binary as the binary_image, the "architecture" label is added under the "Labels" section on an index image. This is done for the OCP cluster to recognize the arch of the image. This is an OCP specific thing and it's not necessary that the "architecture" label will be added under "Labels" if a user specifies any other binary_image. Hence, in-case the label is missing from the index, do not fail the request.
Refers to CLOUDDST-19860