Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable celery task deduplication #558

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

lipoja
Copy link
Contributor

@lipoja lipoja commented Aug 8, 2023

Before each task execution, instruct the worker to check if this task is a duplicate message.

Deduplication occurs only with tasks that have the same identifier, enabled late acknowledgment, were redelivered by the message broker and their state is SUCCESS in the result backend.

[CLOUDDST-19499]

xDaile
xDaile previously approved these changes Aug 8, 2023
Copy link
Collaborator

@yashvardhannanavati yashvardhannanavati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the missing type?

worker_deduplicate_successful_tasks: bool = True

Before each task execution, instruct the worker to check if this task is a duplicate message.

Deduplication occurs only with tasks that have the same identifier, enabled late acknowledgment, were redelivered by the message broker and their state is SUCCESS in the result backend.

[CLOUDDST-19499]
@lipoja
Copy link
Contributor Author

lipoja commented Aug 8, 2023

Could you please add the missing type?

worker_deduplicate_successful_tasks: bool = True

Added, please review again

@lipoja lipoja merged commit 2c3fee0 into release-engineering:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants