Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding filtering builds based on from_index #513

Merged
merged 1 commit into from
May 3, 2023
Merged

Adding filtering builds based on from_index #513

merged 1 commit into from
May 3, 2023

Conversation

lipoja
Copy link
Contributor

@lipoja lipoja commented Apr 27, 2023

CLOUDDST-18396

chandwanitulsi
chandwanitulsi reviewed Apr 28, 2023
View reviewed changes
chandwanitulsi
chandwanitulsi reviewed Apr 28, 2023
View reviewed changes
chandwanitulsi
chandwanitulsi reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor

@chandwanitulsi chandwanitulsi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor Comments, Other than that looks good, please add tests

@lipoja lipoja force-pushed the from_index_filter branch 2 times, most recently from 71b2363 to 6b8be28 Compare May 2, 2023 14:42
@chandwanitulsi
Copy link
Contributor

Code is ready to approve, just waiting on accidental add check

xDaile
xDaile reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@xDaile xDaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise LGTM.

@yashvardhannanavati
Copy link
Collaborator

LGTM! Waiting for the above comments to get resolved

@lipoja lipoja force-pushed the from_index_filter branch from 6b8be28 to cd0cf99 Compare May 3, 2023 09:00
@lipoja lipoja merged commit de14245 into release-engineering:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandwanitulsi chandwanitulsi chandwanitulsi approved these changes

@xDaile xDaile xDaile approved these changes

@yashvardhannanavati yashvardhannanavati Awaiting requested review from yashvardhannanavati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lipoja @chandwanitulsi @yashvardhannanavati @xDaile