Allow binaryless images to have the hidden DB

Remove a bad conditional which prevents binaryless images to have a
hidden DB.

Signed-off-by: Jonathan Gangi <jgangi@redhat.com>

iib/workers/tasks/opm_operations.py

@@ -647,11 +647,10 @@ def create_dockerfile(
             log.info('Rewriting Dockerfile %s with newly generated by opm.', dockerfile_path)
         os.rename(dockerfile_path_opm_default, dockerfile_path)
 
-    if binary_image != "scratch":
-        db_path = get_worker_config()['hidden_index_db_path']
-        rel_path_index_db = os.path.relpath(index_db, base_dir)
-        with open(dockerfile_path, 'a') as f:
-            f.write(f'\nADD {rel_path_index_db} {db_path}\n')
+    db_path = get_worker_config()['hidden_index_db_path']
+    rel_path_index_db = os.path.relpath(index_db, base_dir)
+    with open(dockerfile_path, 'a') as f:
+        f.write(f'\nADD {rel_path_index_db} {db_path}\n')
 
     log.info("Dockerfile was successfully generated.")
     return dockerfile_path

tests/test_workers/test_tasks/test_opm_operations.py

@@ -383,6 +383,8 @@ def test_create_dockerfile_binaryless(tmpdir, dockerfile):
         # Set DC-specific label for the location of the DC root directory
         # in the image
         LABEL operators.operatorframework.io.index.configs.v1=/configs
+
+        ADD database/index.db /var/lib/iib/_hidden/do.not.edit.db
         '''
     )
     assert dockerfile == expected_dockerfile