Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: f.el no longer byte-compiles under Emacs 24.5 #125

Open
wolfmanx opened this issue Apr 8, 2023 · 2 comments
Open

[Bug]: f.el no longer byte-compiles under Emacs 24.5 #125

wolfmanx opened this issue Apr 8, 2023 · 2 comments
Labels

Comments

@wolfmanx
Copy link

wolfmanx commented Apr 8, 2023

Expected behavior

f.el should properly byte-compile with Emacs 24.5.

Actual behavior

Since commit 7bb1d34, f.el no longer byte-compiles under Emacs 24.5.

The reason for the failure is that pcase does not recognize the 'ATOM UPAT. Since the corresponding `ATOM QPAT is equivalent, the fix is trivial and there is no need to require Emacs 25.

f.el version

master

Emacs version

something else (please specify)

Relevant code or log output

Compiling file /home/sw/.emacs.d/elpa/f-20230116.1032/f.el at Sat Apr  8 19:19:07 2023
f.el:462:1:Error: Unknown upattern `(quote any)'
@wolfmanx wolfmanx added the bug label Apr 8, 2023
@Phundrak
Copy link
Collaborator

Support for Emacs 24 was indeed removed a few months ago. As it is relatively old (its last update dates from around seven years ago) and I cannot easily test Emacs 24 on my machine, it is not very high on my priority list.

If you think this could be an easy fix, feel free to submit a pull request, including adding back Emacs 24.5 in the CI!

@Phundrak Phundrak reopened this Dec 12, 2023
@Phundrak
Copy link
Collaborator

Wrong issue reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants