baskets: credit types are not checked in allowed classes

[technicallyty]

Summary of Bug

in the Create method for the basket submodule, we have allowed_classes, and credit_type_abbreviation as some of the basket creation criteria. However, we never actually check if the classes in allowed_classes have the same type specified in credit_type_abbreviation.

This isn't chain-breaking, but it could allow some wonky/bogus baskets to be created. The Put method will still make sure credits being placed in the basket adhere to the credit type AND is one of the allowed classes.

Version

https://github.com/regen-network/regen-ledger/tree/release/v3.0.x and current master branch 88a4b31 (latest commit)

Steps to Reproduce

1. create a basket with any credit type, and pass in class Id's that do not adhere to that credit type
2. basket creation succeeds

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[technicallyty]

@robert-zaremba have you started on this? i can have this done in #935