Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement escrow model for sell orders #821

Closed
Tracked by #818
ryanchristo opened this issue Mar 3, 2022 · 0 comments · Fixed by #878
Closed
Tracked by #818

Implement escrow model for sell orders #821

ryanchristo opened this issue Mar 3, 2022 · 0 comments · Fixed by #878
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Feature New feature or request

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Mar 3, 2022

Summary

For now, we have decided to implement an escrow model for sell orders. At a future date, we might want to consider an escrow module for buy orders but this is out-of-scope for this issue.

We will also need to add a field to the balance in the proto files for "escrowed balance" or "in sell orders". The total balance will include the escrow balance and the tradable balance.

@ryanchristo ryanchristo changed the title Update storefront to use escrow model Decide on using escrow model for storefront Mar 3, 2022
@ryanchristo ryanchristo added the Scope: x/ecocredit Issues that update the x/ecocredit module label Mar 3, 2022
@ryanchristo ryanchristo changed the title Decide on using escrow model for storefront Implement escrow model for sell orders Mar 8, 2022
@ryanchristo ryanchristo added this to the v4.0 - Llangorse Upgrade milestone Mar 8, 2022
@ryanchristo ryanchristo added the Type: Feature New feature or request label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants