-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add list of eco credit measurement units for validation #429
Comments
@aaronc any thoughts on this? Should we include in v4.0 upgrade? |
I would consider this nice to have |
I think this might need more consideration. When attempting to write an example for biodiversity, I was not sure how to define the unit and whether that unit would fall under the SI. We also use "metric ton CO2 equivalent" in our current "carbon" credit type. I'm going to move this issue out of our current v4.0 milestone and maybe discuss with Sam before someone picks it up. |
Having on chain validation is probably too restrictive. "metric ton CO2e" is more useful and would fail validation |
Summary
add a list of valid SI units for credit type validation
Problem Definition
in #428 we implemented credit types as a governance param which include SI units such as kg, ton, etc for each type. It would be nice to validate these parameters with a canonical list of valid SI units
Proposal
add a list of valid SI units similar to below:
For Admin Use
The text was updated successfully, but these errors were encountered: