Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of ecocredit fees #1157

Closed
4 tasks
Tracked by #818
ryanchristo opened this issue Jun 6, 2022 · 1 comment · Fixed by #1167
Closed
4 tasks
Tracked by #818

Inconsistent handling of ecocredit fees #1157

ryanchristo opened this issue Jun 6, 2022 · 1 comment · Fixed by #1167
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature

Comments

@ryanchristo
Copy link
Member

ryanchristo commented Jun 6, 2022

Summary

We are currently burning the required fee amount when creating a credit class and sending the required fee amount to the community funding pool when creating a basket.

I remember discussing the credit class fee and deciding to burn the required fee (discussed in relation to #835, which we then decided to icebox) but I don't recall deciding to do something different with the basket fee.

Problem Definition

Is this implemented as intended or should we consider burning both or sending both the community funding pool?

Proposal

Should we burn both or send both to the community funding pool?


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo
Copy link
Member Author

After raising this internally, it looks like we are leaning towards burning both.

@ryanchristo ryanchristo added this to the v4.0 - Llangorse Upgrade milestone Jun 7, 2022
@ryanchristo ryanchristo added the Scope: x/ecocredit Issues that update the x/ecocredit module label Jun 7, 2022
@ryanchristo ryanchristo self-assigned this Jun 7, 2022
@ryanchristo ryanchristo added Type: Refactor A code change that neither fixes a bug nor adds a feature and removed Type: Fix labels Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant