Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent address fields in ecocredit proto definitions #1080

Closed
4 tasks
Tracked by #818
ryanchristo opened this issue May 3, 2022 · 0 comments · Fixed by #1153
Closed
4 tasks
Tracked by #818

Inconsistent address fields in ecocredit proto definitions #1080

ryanchristo opened this issue May 3, 2022 · 0 comments · Fixed by #1153
Assignees
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature

Comments

@ryanchristo
Copy link
Member

ryanchristo commented May 3, 2022

Summary

Audit address field names and make sure we are using consistent names. For example:

  • In MsgSell, MsgUpdateSellOrders, EventUpdateSellOrders, and EventSell we use owner
  • In MsgCancelSellOrder, SellOrder we use seller

Problem Definition

Using different field names to reference the same address is confusing.

Proposal

  • Update all instances of owner within the context of sell order to seller (or vice versa)
  • Audit ecocredit proto definitions for address field names and make other changes if necessary

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added the Scope: x/ecocredit Issues that update the x/ecocredit module label May 3, 2022
@ryanchristo ryanchristo changed the title Inconsistent address fields in ecocredit and marketplace Inconsistent address fields in ecocredit proto definitions May 3, 2022
@ryanchristo ryanchristo added the Type: Refactor A code change that neither fixes a bug nor adds a feature label May 7, 2022
@ryanchristo ryanchristo added this to the v4.0 - Llangorse Upgrade milestone Jun 1, 2022
@ryanchristo ryanchristo self-assigned this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Type: Refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant